[Data] - Actor retry if there's a failure in __init__#59105
Merged
alexeykudinkin merged 8 commits intoray-project:masterfrom Dec 5, 2025
Merged
[Data] - Actor retry if there's a failure in __init__#59105alexeykudinkin merged 8 commits intoray-project:masterfrom
__init__#59105alexeykudinkin merged 8 commits intoray-project:masterfrom
Conversation
Signed-off-by: Goutam <[email protected]>
goutamvenkat-anyscale
changed the title
goutamvenkat-anyscale
added
data
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature for handling actor initialization failures by adding a configurable retry mechanism. The implementation is clear, and the accompanying tests effectively validate the new logic. I have a couple of suggestions to enhance robustness and clarity.
python/ray/data/_internal/execution/operators/actor_pool_map_operator.py
Outdated
Show resolved
Hide resolved
![cursor[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
python/ray/data/_internal/execution/operators/actor_pool_map_operator.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/execution/operators/actor_pool_map_operator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Goutam <[email protected]>
python/ray/data/_internal/execution/operators/actor_pool_map_operator.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/execution/operators/actor_pool_map_operator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Goutam <[email protected]>
goutamvenkat-anyscale
changed the title
__init__
python/ray/data/_internal/execution/operators/actor_pool_map_operator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Goutam <[email protected]>
Signed-off-by: Goutam <[email protected]>
python/ray/data/_internal/execution/operators/actor_pool_map_operator.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/execution/operators/actor_pool_map_operator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Goutam <[email protected]>
alexeykudinkin
approved these changes
Dec 5, 2025
Comment on lines
+600
to
+601
| last_exception = e | ||
| attempt += 1 |
Contributor
There was a problem hiding this comment.
What i meant by prev comment was that we must log every exception
Signed-off-by: Goutam <[email protected]>
alexeykudinkin
approved these changes
Dec 5, 2025
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…59105) ## Description Ray Core doesn't restart till actors if `__init__` fails. So Ray Data has to manually retry actor init failures ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Goutam <[email protected]> Signed-off-by: peterxcli <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ray Core doesn't restart till actors if
__init__fails. So Ray Data has to manually retry actor init failuresRelated issues
Additional information