[Serve][6/n] Add app/deployment status metrics#59244
Merged
abrarsheikh merged 6 commits intomasterfrom Dec 18, 2025
Merged
Conversation
Signed-off-by: abrar <[email protected]>
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces new metrics for tracking application and deployment statuses in Ray Serve. The changes include adding to_numeric() methods to status enums and instrumenting the state managers to report these metrics as Prometheus gauges. A new test is also added to verify the correctness of these metrics.
My review focuses on the consistency of the new metrics and the correctness of the tests. I've found a bug in the new test where it re-verifies a deployment's status instead of checking the one that's expected to change. I've also suggested re-ordering the numeric values for ApplicationStatus to be more intuitive and consistent with DeploymentStatus.
Signed-off-by: abrar <[email protected]>
Signed-off-by: abrar <[email protected]>
ray-gardener
bot
added
serve
harshit-anyscale
requested changes
Dec 17, 2025
Signed-off-by: abrar <[email protected]>
akyang-anyscale
approved these changes
Dec 17, 2025
harshit-anyscale
approved these changes
Dec 18, 2025
zzchun
pushed a commit
to zzchun/ray
that referenced
this pull request
Dec 18, 2025
fixes ray-project#59218 --------- Signed-off-by: abrar <[email protected]>
Yicheng-Lu-llll
pushed a commit
to Yicheng-Lu-llll/ray
that referenced
this pull request
Dec 22, 2025
fixes ray-project#59218 --------- Signed-off-by: abrar <[email protected]>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
fixes ray-project#59218 --------- Signed-off-by: abrar <[email protected]> Signed-off-by: peterxcli <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #59218