[Data] Clarify resource_limits refers to logical resources#60109
Merged
bveeramani merged 2 commits intomasterfrom Jan 14, 2026
Merged
[Data] Clarify resource_limits refers to logical resources#60109bveeramani merged 2 commits intomasterfrom
resource_limits refers to logical resources#60109bveeramani merged 2 commits intomasterfrom
Conversation
Signed-off-by: Balaji Veeramani <[email protected]>
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the docstring for the resource_limits attribute in the ExecutionOptions class to be more precise. The term 'soft limit' is correctly removed as the limit is enforced as a hard limit. 'Resource usage' is replaced with 'logical resources', which accurately reflects that the limits apply to logical entities like CPU/GPU slots. This change improves the clarity and correctness of the documentation. The change looks good and I have no further comments.
iamjustinhsu
approved these changes
Jan 13, 2026
python/ray/data/_internal/execution/interfaces/execution_options.py
Outdated
Show resolved
Hide resolved
…ns.py Co-authored-by: iamjustinhsu <[email protected]> Signed-off-by: Balaji Veeramani <[email protected]>
ryankert01
approved these changes
Jan 14, 2026
rushikeshadhav
pushed a commit
to rushikeshadhav/ray
that referenced
this pull request
Jan 14, 2026
…ject#60109) Follow up to ray-project#52573 (comment) --------- Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: iamjustinhsu <[email protected]>
jeffery4011
pushed a commit
to jeffery4011/ray
that referenced
this pull request
Jan 20, 2026
…ject#60109) Follow up to ray-project#52573 (comment) --------- Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: iamjustinhsu <[email protected]> Signed-off-by: jeffery4011 <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
…ject#60109) Follow up to ray-project#52573 (comment) --------- Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: iamjustinhsu <[email protected]>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…ject#60109) Follow up to ray-project#52573 (comment) --------- Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: iamjustinhsu <[email protected]> Signed-off-by: peterxcli <[email protected]>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…ject#60109) Follow up to ray-project#52573 (comment) --------- Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: iamjustinhsu <[email protected]> Signed-off-by: peterxcli <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #52573 (comment)