[Data][Train] Remove top-level ray.data imports to decouple Ray Train from Ray Data#60292
Merged
bveeramani merged 7 commits intoray-project:masterfrom Jan 20, 2026
Merged
Conversation
… from Ray Data Signed-off-by: Haichuan Hu <[email protected]>
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively decouples Ray Train from Ray Data by removing top-level ray.data imports. The changes are implemented consistently across all modified files, using TYPE_CHECKING guards for type annotations and lazy, inline imports for runtime dependencies. This is a solid refactoring that improves modularity and dependency management within the Ray ecosystem. The implementation is clean and correct, and I have no further suggestions.
ray-gardener
bot
added
train
bveeramani
reviewed
Jan 20, 2026
Member
bveeramani
left a comment
bveeramani
left a comment
There was a problem hiding this comment.
LGTM overall. Only questions are about _get_execution_options_class() and _get_execution_resources_class()
Comment on lines
+12
to
+25
| def _get_execution_options_class(): | ||
| """Lazy import of ExecutionOptions.""" | ||
| from ray.data import ExecutionOptions | ||
|
|
||
| return ExecutionOptions | ||
|
|
||
|
|
||
| def _get_execution_resources_class(): | ||
| """Lazy import of ExecutionResources.""" | ||
| from ray.data._internal.execution.interfaces.execution_options import ( | ||
| ExecutionResources, | ||
| ) | ||
|
|
||
| return ExecutionResources |
Member
There was a problem hiding this comment.
What happens if we import these under if TYPE_CHECKING? If that doesn't work, what happens if we import these in the function definitions (e.g., in the DataConfig constructor?)
… from Ray Data Signed-off-by: Haichuan Hu <[email protected]>
… from Ray Data Signed-off-by: Haichuan Hu <[email protected]>
bveeramani
approved these changes
Jan 20, 2026
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
JasonLi1909
approved these changes
Jan 20, 2026
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
… from Ray Data (ray-project#60292) ## Description Remove all top-level imports of `ray.data` from the `ray.train` module. Imports needed only for type annotations should be guarded behind if `TYPE_CHECKING:`. Imports needed at runtime should be moved inline (lazy imports within functions/methods). ## Related issues Fixes ray-project#60152. --------- Signed-off-by: Haichuan Hu <[email protected]> Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]> Signed-off-by: jinbum-kim <[email protected]>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 1, 2026
… from Ray Data (ray-project#60292) ## Description Remove all top-level imports of `ray.data` from the `ray.train` module. Imports needed only for type annotations should be guarded behind if `TYPE_CHECKING:`. Imports needed at runtime should be moved inline (lazy imports within functions/methods). ## Related issues Fixes ray-project#60152. --------- Signed-off-by: Haichuan Hu <[email protected]> Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]> Signed-off-by: 400Ping <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
… from Ray Data (ray-project#60292) ## Description Remove all top-level imports of `ray.data` from the `ray.train` module. Imports needed only for type annotations should be guarded behind if `TYPE_CHECKING:`. Imports needed at runtime should be moved inline (lazy imports within functions/methods). ## Related issues Fixes ray-project#60152. --------- Signed-off-by: Haichuan Hu <[email protected]> Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
… from Ray Data (ray-project#60292) ## Description Remove all top-level imports of `ray.data` from the `ray.train` module. Imports needed only for type annotations should be guarded behind if `TYPE_CHECKING:`. Imports needed at runtime should be moved inline (lazy imports within functions/methods). ## Related issues Fixes ray-project#60152. --------- Signed-off-by: Haichuan Hu <[email protected]> Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]> Signed-off-by: peterxcli <[email protected]>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
… from Ray Data (ray-project#60292) ## Description Remove all top-level imports of `ray.data` from the `ray.train` module. Imports needed only for type annotations should be guarded behind if `TYPE_CHECKING:`. Imports needed at runtime should be moved inline (lazy imports within functions/methods). ## Related issues Fixes ray-project#60152. --------- Signed-off-by: Haichuan Hu <[email protected]> Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]> Signed-off-by: peterxcli <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove all top-level imports of
ray.datafrom theray.trainmodule. Imports needed only for type annotations should be guarded behind ifTYPE_CHECKING:. Imports needed at runtime should be moved inline (lazy imports within functions/methods).@tianyi-ge
Related issues
Fixes #60152.