[Data] Demote Sort from requiring preserve_order#60555
Merged
alexeykudinkin merged 2 commits intomasterfrom Jan 28, 2026
Merged
[Data] Demote Sort from requiring preserve_order#60555alexeykudinkin merged 2 commits intomasterfrom
Sort from requiring preserve_order#60555alexeykudinkin merged 2 commits intomasterfrom
Conversation
Signed-off-by: Alexey Kudinkin <[email protected]>
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request successfully removes Sort from the list of logical operators that implicitly require order preservation. This change aligns with the stated goal of demoting Sort from always enforcing preserve_order=True in the execution plan. The modifications are clear and directly implement the described intent.
iamjustinhsu
approved these changes
Jan 28, 2026
Contributor
iamjustinhsu
left a comment
iamjustinhsu
left a comment
There was a problem hiding this comment.
do u know why Sort was included originally?
Signed-off-by: Alexey Kudinkin <[email protected]>
![cursor[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| for op in self._logical_plan.dag.post_order_iter(): | ||
| if isinstance(op, (Zip, Sort)): | ||
| if isinstance(op, Zip): |
There was a problem hiding this comment.
Sort output may return blocks out of order
Medium Severity
Removing Sort from require_preserve_order() can cause sorted data to be returned out of order when downstream MapOperators process blocks in parallel. The Sort operation establishes global ordering (block 0 has smallest values, block 1 has next range, etc.), but without preserve_order=True, downstream operators use FIFOBundleQueue which returns blocks in completion order rather than input order. If a later block completes before an earlier one, the sorted order is broken.
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
## Description This removes the requirement for pipelines having `Sort` operations to actually require `preserve_order=True`. This is an unnecessary strict requirement that has adversarial side-effects, and is strictly not required as there's no global ordering between the blocks established. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Alexey Kudinkin <[email protected]> Signed-off-by: jinbum-kim <[email protected]>
limarkdcunha
pushed a commit
to limarkdcunha/ray
that referenced
this pull request
Jan 29, 2026
## Description This removes the requirement for pipelines having `Sort` operations to actually require `preserve_order=True`. This is an unnecessary strict requirement that has adversarial side-effects, and is strictly not required as there's no global ordering between the blocks established. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Alexey Kudinkin <[email protected]>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 1, 2026
## Description This removes the requirement for pipelines having `Sort` operations to actually require `preserve_order=True`. This is an unnecessary strict requirement that has adversarial side-effects, and is strictly not required as there's no global ordering between the blocks established. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Alexey Kudinkin <[email protected]> Signed-off-by: 400Ping <[email protected]>
ans9868
pushed a commit
to ans9868/ray
that referenced
this pull request
Feb 18, 2026
## Description This removes the requirement for pipelines having `Sort` operations to actually require `preserve_order=True`. This is an unnecessary strict requirement that has adversarial side-effects, and is strictly not required as there's no global ordering between the blocks established. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Alexey Kudinkin <[email protected]> Signed-off-by: Adel Nour <[email protected]>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
## Description This removes the requirement for pipelines having `Sort` operations to actually require `preserve_order=True`. This is an unnecessary strict requirement that has adversarial side-effects, and is strictly not required as there's no global ordering between the blocks established. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Alexey Kudinkin <[email protected]> Signed-off-by: peterxcli <[email protected]>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
## Description This removes the requirement for pipelines having `Sort` operations to actually require `preserve_order=True`. This is an unnecessary strict requirement that has adversarial side-effects, and is strictly not required as there's no global ordering between the blocks established. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Alexey Kudinkin <[email protected]> Signed-off-by: peterxcli <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the requirement for pipelines having
Sortoperations to actually requirepreserve_order=True.This is an unnecessary strict requirement that has adversarial side-effects, and is strictly not required as there's no global ordering between the blocks established.
Related issues
Additional information