test: add short flag for store unit test because it's using dockertest for integration tests#369
Merged
rahmatrhd merged 1 commit intoraystack:mainfrom Feb 23, 2023
Conversation
…t for integration tests
swallowstalker
requested review from
AkarshSatija,
bsushmith,
mabdh,
rahmatrhd and
ravisuhag
as code owners
Pull Request Test Coverage Report for Build 4245835458
💛 - Coveralls |
bsushmith
approved these changes
Feb 23, 2023
rahmatrhd
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try to solve issue #354 so that people using Guardian will have options of disabling store package test which uses dockertest that requires connecting to
/var/run/docker.sock$ go test -count=1 -race -v -short github.com/odpf/guardian/internal/store/postgres === RUN TestActivityRepository activity_repository_test.go:32: --- SKIP: TestActivityRepository (0.00s) === RUN TestAppealRepository appeal_repository_test.go:393: --- SKIP: TestAppealRepository (0.00s) === RUN TestApprovalRepository approval_repository_test.go:30: --- SKIP: TestApprovalRepository (0.00s) === RUN TestGrantRepository grant_repository_test.go:34: --- SKIP: TestGrantRepository (0.00s) === RUN TestPolicyRepository policy_repository_test.go:208: --- SKIP: TestPolicyRepository (0.00s) === RUN TestProviderRepository provider_repository_test.go:381: --- SKIP: TestProviderRepository (0.00s) === RUN TestResourceRepository resource_repository_test.go:424: --- SKIP: TestResourceRepository (0.00s) PASS ok github.com/odpf/guardian/internal/store/postgres 0.691s