Skip to content

feat: add pagination support in ListUserApproval and ListApprovals API#378

Merged
ravisuhag merged 4 commits intomainfrom
add-pagination
Apr 21, 2023
Merged

feat: add pagination support in ListUserApproval and ListApprovals API#378
ravisuhag merged 4 commits intomainfrom
add-pagination

Conversation

@Chief-Rishab
Copy link
Member

@Chief-Rishab Chief-Rishab commented Apr 11, 2023

  • add pagination support in ListUserApprovals api
  • add pagination support in ListApprovals api
  • update buf version
  • update docs

@coveralls
Copy link

coveralls commented Apr 11, 2023

Pull Request Test Coverage Report for Build 4669055275

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 75.284%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/postgres/approval_repository.go 4 6 66.67%
Totals Coverage Status
Change from base Build 4601889208: 0.004%
Covered Lines: 7959
Relevant Lines: 10572

💛 - Coveralls

@Chief-Rishab Chief-Rishab marked this pull request as ready for review April 11, 2023 15:10
@ravisuhag ravisuhag merged commit feb5711 into main Apr 21, 2023
@ravisuhag ravisuhag deleted the add-pagination branch April 21, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants