upgrade jscodeshift, redo bin/npx experience, pass tests#229
Merged
threepointone merged 1 commit intoreactjs:masterfrom Jul 18, 2019
Merged
upgrade jscodeshift, redo bin/npx experience, pass tests#229threepointone merged 1 commit intoreactjs:masterfrom
threepointone merged 1 commit intoreactjs:masterfrom
Conversation
Contributor
Author
|
|
Contributor
Author
|
I'll fix the build after some sleep 😴 |
threepointone
force-pushed
the
fix-npx
branch
3 times, most recently
from
4f7b4bd to
06b88d0
Compare
threepointone
force-pushed
the
fix-npx
branch
3 times, most recently
from
63f508d to
fe70f37
Compare
To workaround an npx bug (which isn't even an issue in newer npx, sigh), I had to redo the cli experience. I copied it wholesale from jest-codemods, and rewrote it for react-codemods. Updating jscodeshift also broke some tests, which I fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To workaround an npx bug (which isn't even an issue in newer npx, sigh), I had to redo the cli experience. I copied it wholesale from jest-codemods, and rewrote it for react-codemods. Updating jscodeshift also broke some tests, which I fixed.