This repository was archived by the owner on Oct 10, 2023. It is now read-only.
Replace MustCompile with Compile for non-hardcoded regexes#238
Merged
thepetk merged 7 commits intoredhat-developer:mainfrom Jun 19, 2023
Merged
Conversation
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
mike-hoang
approved these changes
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are two cases that we are compiling a regex with
regexp.MustCompileand a dynamic string:One, for express js port detection
Second, for
nodejs_detector.getPortFromScript()func:As
MustCompileaction for error is panic this PR replaces those two functions withCompileand handles any error case accordingly.A test resource is added along with the
TestComponentDetectionOnExpresstest, ensuring that a failure with regexp.Compile will be handled and the code will not panic.Which issue(s) does this PR fix
fixes #220
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer
The repo that this issue was first seen was the one mentioned inside the issue: https://github.com/backstage/backstage.