Skip to content

Update devfile data in integration tests#6140

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
valaparthvi:fix-devfile-stack-tests
Sep 20, 2022
Merged

Update devfile data in integration tests#6140
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
valaparthvi:fix-devfile-stack-tests

Conversation

@valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Sep 20, 2022

What type of PR is this:
/kind tests
/area testing

What does this PR do / why we need it:
This PR fixes the tests to use latest devfile stack.
Which issue(s) this PR fixes:

Fixes part of #6138

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Sep 20, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit f55b7fa
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/632988cfdb4ce90008ffc2f3

@openshift-ci openshift-ci bot added kind/tests area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels Sep 20, 2022
@openshift-ci openshift-ci bot requested review from feloy and rnapoles-rh September 20, 2022 09:33
@valaparthvi valaparthvi changed the title Update devfile data in integration tests WIP: Update devfile data in integration tests Sep 20, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Sep 20, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@valaparthvi valaparthvi changed the title WIP: Update devfile data in integration tests Update devfile data in integration tests Sep 20, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Sep 20, 2022
@valaparthvi valaparthvi requested a review from rm3l September 20, 2022 09:58
@feloy
Copy link
Contributor

feloy commented Sep 20, 2022

/approve

thanks @valaparthvi for this fix

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 20, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 20, 2022
@rm3l
Copy link
Member

rm3l commented Sep 20, 2022

Not sure why, but some interactive tests are not passing on Windows:

-----------------------------
+++
------------------------------
+ [FAILED] [126.761 seconds]
odo add binding interactive command tests
C:/Users/Administrator.ANSIBLE-TEST-VS/2038/tests/integration/interactive_add_binding_test.go:16
  when running a deployment
  C:/Users/Administrator.ANSIBLE-TEST-VS/2038/tests/integration/interactive_add_binding_test.go:300
    [It] should successfully add binding without devfile (custom naming strategy: "")

...
error while sending or expecting line: "Select service instance you want to bind to:"
  === output of command '["odo" "add" "binding"]' read so far ===

...
? Do you want to list services from:  [Use arrows to move, type to filter]      
  > current namespaceXC
    all accessible namespacesXC?25h?25lHI?25h
  ======================
  Unexpected error:
      <*xpty.errPassthroughTimeout | 0xc0009d8010>: {
          error: <*errors.errorString | 0xc0009d8000>{
              s: "passthrough i/o timeout",
          },
      }
      passthrough i/o timeout
  occurred
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/2038/tests/helper/helper_interactive.go:111

...

Summarizing 1 Failure:
  [FAIL] odo add binding interactive command tests when running a deployment [It] should successfully add binding without devfile (custom naming strategy: "")
  C:/Users/Administrator.ANSIBLE-TEST-VS/2038/tests/helper/helper_interactive.go:111

Ran 376 of 386 Specs in 1186.820 seconds
FAIL! -- 375 Passed | 1 Failed | 0 Pending | 10 Skipped

As they do not seem related to this PR, I think we could override them (to unblock #6137), no?

@feloy
Copy link
Contributor

feloy commented Sep 20, 2022

/override windows-integration-test/Windows-test

Flaky tests and/or unstable cluster for Windows tests

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test

Flaky tests and/or unstable cluster for Windows tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3a24486 into redhat-developer:main Sep 20, 2022
@valaparthvi valaparthvi mentioned this pull request Sep 23, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants