Skip to content

Revert devfile python ID#6164

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
valaparthvi:python-fix
Sep 23, 2022
Merged

Revert devfile python ID#6164
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
valaparthvi:python-fix

Conversation

@valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Sep 23, 2022 •
edited
Loading

What type of PR is this:
/kind tests
/area testing

What does this PR do / why we need it:
This PR reverts the changes related to python devfile in integration tests from #6140.
Reason: devfile/registry#125
Which issue(s) this PR fixes:

Fixes part of #6138

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Sep 23, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 5b01a4e
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/632d6a82914ce20008c7734f

@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2022

@valaparthvi: The label(s) area/tests cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this:
/kind tests
/area tests

What does this PR do / why we need it:
This PR reverts the changes related to python devfile in integration tests from #6140
Which issue(s) this PR fixes:

Fixes part of #6138

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from anandrkskd and feloy September 23, 2022 07:43
@odo-robot
Copy link

odo-robot bot commented Sep 23, 2022 •
edited
Loading

Unit Tests on commit 85c282b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 23, 2022 •
edited
Loading

Validate Tests on commit 85c282b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 23, 2022 •
edited
Loading

Kubernetes Tests on commit 85c282b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 23, 2022 •
edited
Loading

OpenShift Tests on commit 85c282b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 23, 2022 •
edited
Loading

Windows Tests (OCP) on commit 85c282b finished successfully.
View logs: TXT HTML

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 23, 2022
@dharmit
Copy link
Member

dharmit commented Sep 23, 2022

/approve

@valaparthvi valaparthvi added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Sep 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 23, 2022
@feloy
Copy link
Contributor

feloy commented Sep 23, 2022

/override ci/prow/v4.11-integration-e2e
Tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2022

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ``

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/unit-and-validate-test
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.11-integration-e2e
  • ci/prow/v4.12-images
  • ci/prow/v4.9-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-unit-and-validate-test
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.11-integration-e2e
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.9-images
  • tide
  • validator/Validate

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ci/prow/v4.11-integration-e2e
Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor Author

valaparthvi commented Sep 23, 2022

/override ci/prow/v4.11-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/v4.11-integration-e2e

Details

In response to this:

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 643eef7 into redhat-developer:main Sep 23, 2022
rm3l pushed a commit that referenced this pull request Sep 27, 2022
@valaparthvi @rm3l
Revert devfile python ID (#6164)
b333b08
@rm3l rm3l mentioned this pull request Sep 27, 2022
Merged
3 tasks
@feloy feloy mentioned this pull request Oct 3, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@feloy feloy Awaiting requested review from feloy

Assignees

@rm3l rm3l

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@valaparthvi @dharmit @feloy @rm3l @openshift-merge-robot