Update odo to use go 1.18 by dharmit · Pull Request #6166 · redhat-developer/odo

dharmit · 2022-09-23T13:09:15Z

Signed-off-by: Dharmit Shah [email protected]

What type of PR is this:
/kind feature

What does this PR do / why we need it:
$subject

Which issue(s) this PR fixes:

Fixes #6090

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:

I tested make validate and make test locally before opening the PR. Not sure if there was any other Makefile target that I should have tested locally.
For a list of steps I followed, PTAL Upgrade odo to use go 1.18 #6090 (comment).

netlify · 2022-09-23T13:09:25Z

✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	`50bdddc`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/636b5d0f27fd700008a2f25c
😎 Deploy Preview	https://deploy-preview-6166--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

odo-robot · 2022-09-23T13:16:41Z

Unit Tests on commit d3d5986 finished successfully.
View logs: TXT HTML

odo-robot · 2022-09-23T13:25:15Z

Validate Tests on commit d3d5986 finished successfully.
View logs: TXT HTML

odo-robot · 2022-09-23T13:27:41Z

Kubernetes Tests on commit d3d5986 finished successfully.
View logs: TXT HTML

odo-robot · 2022-09-23T13:28:17Z

OpenShift Tests on commit d3d5986 finished successfully.
View logs: TXT HTML

odo-robot · 2022-09-23T13:34:39Z

Windows Tests (OCP) on commit d3d5986 finished successfully.
View logs: TXT HTML

anandrkskd · 2022-09-23T13:37:12Z

@dharmit, just wanted to know if we have checked with EXD team if they have go 1.18 on rhel8, I remember we have go1.18 available for rhel7.

feloy · 2022-09-23T14:20:42Z

pkg/odo/util/cmdutils.go

 	"github.com/redhat-developer/odo/pkg/machineoutput"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
+	"os"


stdlib imports ("os" here) should appear in the first block of imports

IDE did something. I changed some settings, and hope it's not a problem any more. At least, I couldn't find any as far as I checked. Thanks for catching. 👍🏾

feloy · 2022-09-23T14:21:07Z

tests/integration/cmd_namespace_test.go

+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"


Non stdlib imports should not appear in first block of imports

#6166 (comment)

dharmit · 2022-10-03T04:24:18Z

@dharmit, just wanted to know if we have checked with EXD team if they have go 1.18 on rhel8, I remember we have go1.18 available for rhel7.

I have pinged Matej for this. I checked using the brew cli, but couldn't get the answer myself.

anandrkskd · 2022-10-03T05:28:00Z

I have pinged Matej for this. I checked using the brew cli, but couldn't get the answer myself.

I checked for 1.18 on rhel8 but was not able to find it. for rhel 7 its available AFAIR

dharmit · 2022-10-03T06:09:21Z

I have pinged Matej for this. I checked using the brew cli, but couldn't get the answer myself.

I checked for 1.18 on rhel8 but was not able to find it. for rhel 7 its available AFAIR

Indeed. That's exactly what I found. But I saw the list had only up to go 1.10, which seems weird to me because it's too old. That's why I have pinged Matej about it since he would know the best. :)

feloy · 2022-10-03T07:36:13Z

@dharmit All tests fail, did you rebase after this PR? #6164

dharmit · 2022-10-03T11:49:34Z

@dharmit All tests fail, did you rebase after this PR? #6164

I don't remember if I did or didn't. Anyway, rebased now.

sonarqubecloud · 2022-10-03T11:50:01Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

dharmit · 2022-10-03T12:04:05Z

/hold

Putting this on hold to prevent accidental merge till Red Hat Release Engg team says OK to update to 1.18. In the meantime, I'll try to address CI issues and the folks can review/approve it so that it can be merged once we have a go ahead.

odo-robot · 2022-11-04T10:44:50Z

NoCluster Tests on commit d3d5986 finished successfully.
View logs: TXT HTML

dharmit · 2022-11-04T10:45:53Z

/hold

Putting this on hold to prevent accidental merge till Red Hat Release Engg team says OK to update to 1.18. In the meantime, I'll try to address CI issues and the folks can review/approve it so that it can be merged once we have a go ahead.

/hold cancel

Internal systems at RH have been updated to use go 1.18.

feloy · 2022-11-04T16:06:41Z

/approve

openshift-ci · 2022-11-04T16:06:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [feloy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dharmit · 2022-11-08T07:06:08Z

Both failures, NoCluster & OCP prow tests, are attributed to the problem mentioned in #6291 and fixed by #6292.

Signed-off-by: Dharmit Shah <[email protected]>

Erroneously I had used go 1.19 at various places. Signed-off-by: Dharmit Shah <[email protected]>

Fixed a bunch of golangci-lint errors like below: `File is not `gofmt`-ed with `-s`` using the command: `golangci-lint run --fix` Signed-off-by: Dharmit Shah <[email protected]>

.ibm/images/Dockerfile

This is because with go 1.18, `go get` behaves as `go get -d` by default. Which means that it will only download, but not install. Signed-off-by: Dharmit Shah <[email protected]>

sonarqubecloud · 2022-11-09T07:56:38Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

dharmit · 2022-11-09T10:28:15Z

<< End Captured GinkgoWriter Output
  Unexpected error:
      <*url.Error | 0xc000170120>: {
          Op: "Get",
          URL: "http://127.0.0.1:45923/",
          Err: <*errors.errorString | 0xc0000b0100>{s: "EOF"},
      }
      Get "http://127.0.0.1:45923/": EOF
  occurred
  In [It] at: /go/src/github.com/redhat-developer/odo/tests/e2escenarios/e2e_test.go:32
------------------------------

overriding since tests are passing on IBM Cloud

/override ci/prow/v4.11-integration-e2e

openshift-ci · 2022-11-09T10:28:20Z

@dharmit: Overrode contexts on behalf of dharmit: ci/prow/v4.11-integration-e2e

Details

In response to this:

<< End Captured GinkgoWriter Output
 Unexpected error:
     <*url.Error | 0xc000170120>: {
         Op: "Get",
         URL: "http://127.0.0.1:45923/",
         Err: <*errors.errorString | 0xc0000b0100>{s: "EOF"},
     }
     Get "http://127.0.0.1:45923/": EOF
 occurred
 In [It] at: /go/src/github.com/redhat-developer/odo/tests/e2escenarios/e2e_test.go:32
------------------------------

overriding since tests are passing on IBM Cloud

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dharmit requested review from anandrkskd and feloy September 23, 2022 13:09

openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Sep 23, 2022

feloy suggested changes Sep 23, 2022

View reviewed changes

openshift-ci bot assigned feloy Sep 23, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Oct 3, 2022

dharmit closed this Oct 20, 2022

dharmit deleted the fix-6090 branch October 20, 2022 10:07

dharmit restored the fix-6090 branch November 4, 2022 10:27

dharmit reopened this Nov 4, 2022

openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. labels Nov 4, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Nov 4, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 4, 2022

openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. labels Nov 7, 2022

dharmit added 4 commits November 8, 2022 18:49

Update odo to use go 1.18

4acaa4b

Signed-off-by: Dharmit Shah <[email protected]>

Update golangci-lint version in Makefile

1b87a44

Signed-off-by: Dharmit Shah <[email protected]>

Use go 1.18, not go 1.19

a5ad8e1

Erroneously I had used go 1.19 at various places. Signed-off-by: Dharmit Shah <[email protected]>

Rearrange imports; fix golangci-lint errors

dbeb16c

Fixed a bunch of golangci-lint errors like below: `File is not `gofmt`-ed with `-s`` using the command: `golangci-lint run --fix` Signed-off-by: Dharmit Shah <[email protected]>

rm3l requested changes Nov 8, 2022

View reviewed changes

.ibm/images/Dockerfile Show resolved Hide resolved

openshift-ci bot assigned rm3l Nov 8, 2022

Use go install instead of go get

50bdddc

This is because with go 1.18, `go get` behaves as `go get -d` by default. Which means that it will only download, but not install. Signed-off-by: Dharmit Shah <[email protected]>

rm3l approved these changes Nov 9, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 9, 2022

openshift-merge-robot merged commit f062c11 into redhat-developer:main Nov 9, 2022

rm3l mentioned this pull request Feb 9, 2023

Trigger the IBM Cloud Image Workflow on PRs as well #6587

Merged

3 tasks

Conversation

dharmit commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for odo-docusaurus-preview ready!

Uh oh!

odo-robot bot commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anandrkskd commented Sep 23, 2022

Uh oh!

feloy Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

dharmit Oct 3, 2022

Choose a reason for hiding this comment

Uh oh!

feloy Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

dharmit Oct 3, 2022

Choose a reason for hiding this comment

Uh oh!

dharmit commented Oct 3, 2022

Uh oh!

anandrkskd commented Oct 3, 2022

Uh oh!

dharmit commented Oct 3, 2022

Uh oh!

feloy commented Oct 3, 2022

Uh oh!

dharmit commented Oct 3, 2022

Uh oh!

sonarqubecloud bot commented Oct 3, 2022

Uh oh!

dharmit commented Oct 3, 2022

Uh oh!

odo-robot bot commented Nov 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dharmit commented Nov 4, 2022

Uh oh!

feloy commented Nov 4, 2022

Uh oh!

openshift-ci bot commented Nov 4, 2022

Uh oh!

dharmit commented Nov 8, 2022

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 9, 2022

Uh oh!

dharmit commented Nov 9, 2022

Uh oh!

openshift-ci bot commented Nov 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dharmit commented Sep 23, 2022 •

edited

Loading

netlify bot commented Sep 23, 2022 •

edited

Loading

odo-robot bot commented Sep 23, 2022 •

edited

Loading

odo-robot bot commented Sep 23, 2022 •

edited

Loading

odo-robot bot commented Sep 23, 2022 •

edited

Loading

odo-robot bot commented Sep 23, 2022 •

edited

Loading

odo-robot bot commented Sep 23, 2022 •

edited

Loading

odo-robot bot commented Nov 4, 2022 •

edited

Loading