Skip to content

Change expecations to match reality#6292

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
dharmit:fix-6291
Nov 8, 2022
Merged

Change expecations to match reality#6292
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
dharmit:fix-6291

Conversation

@dharmit
Copy link
Member

@dharmit dharmit commented Nov 8, 2022

Signed-off-by: Dharmit Shah [email protected]

What type of PR is this:
/kind tests

What does this PR do / why we need it:
Changes strings to be checked in tests to match what's available in the underlying devfile

Which issue(s) this PR fixes:
Fixes #6291

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
Integration tests should pass.

@netlify
Copy link

netlify bot commented Nov 8, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit db740d2
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6369feb7ac4e3300086f7ede
😎 Deploy Preview https://deploy-preview-6292--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot requested review from feloy and rnapoles-rh November 8, 2022 07:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dharmit dharmit requested review from valaparthvi and removed request for rnapoles-rh November 8, 2022 07:04
@dharmit dharmit mentioned this pull request Nov 8, 2022
Merged
3 tasks
@odo-robot
Copy link

odo-robot bot commented Nov 8, 2022

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 8, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 8, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 8, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Nov 8, 2022

/lgtm
/approve
Thanks for the fix

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 8, 2022
@odo-robot
Copy link

odo-robot bot commented Nov 8, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 8, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@dharmit
Copy link
Member Author

dharmit commented Nov 8, 2022

Looks like a momentory error to me:

<< End Captured GinkgoWriter Output
  Unexpected error:
      <*url.Error | 0xc00093b770>: {
          Op: "Get",
          URL: "http://127.0.0.1:40245/",
          Err: <*errors.errorString | 0xc0000b0100>{s: "EOF"},
      }
      Get "http://127.0.0.1:40245/": EOF
  occurred
  In [It] at: /go/src/github.com/redhat-developer/odo/tests/e2escenarios/e2e_test.go:32
------------------------------

/test v4.11-integration-e2e

@feloy
Copy link
Contributor

feloy commented Nov 8, 2022

/override v4.11-integration-e2e
Tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Nov 8, 2022

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • v4.11-integration-e2e

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/unit-and-validate-test
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.11-integration-e2e
  • ci/prow/v4.12-images
  • ci/prow/v4.9-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-unit-and-validate-test
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.11-integration-e2e
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.9-images
  • tide
  • validator/Validate

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override v4.11-integration-e2e
Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Nov 8, 2022

/override ci/prow/v4.11-integration-e2e
Tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Nov 8, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

Details

In response to this:

/override ci/prow/v4.11-integration-e2e
Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 0d4f5f7 into redhat-developer:main Nov 8, 2022
@dharmit dharmit deleted the fix-6291 branch November 8, 2022 13:18
This was referenced Nov 8, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feloy feloy Awaiting requested review from feloy

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@feloy feloy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integration tests fail due to change in "nodeshift-starters/devfile-sample" repository

3 participants

@dharmit @feloy @openshift-merge-robot