Skip to content

blog: odo with .NET and PostgreSQL on OpenShift#6500

Merged
openshift-merge-robot merged 4 commits intoredhat-developer:mainfrom
kadel:s2i-openshift-example
Feb 22, 2023
Merged

blog: odo with .NET and PostgreSQL on OpenShift#6500
openshift-merge-robot merged 4 commits intoredhat-developer:mainfrom
kadel:s2i-openshift-example

Conversation

@kadel
Copy link
Member

@kadel kadel commented Jan 17, 2023 •
edited by rm3l
Loading

/area documentation

Start converting some old .NET guides to odo v3, and in the process, I realized that this might be a nice blog post for odo.

This guide shows how container-overrides can be leveraged. I think that this could become one of the most important devfile/odo features.

Things to do before merging/publishing:

NOTE:
I was also thinking about breaking this into two posts. One just runs the application with an in-memory database. Then the follow-up post with the PostgreSQL.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website labels Jan 17, 2023
@netlify
Copy link

netlify bot commented Jan 17, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit dc990cd
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63f6071720179c000832d25c
😎 Deploy Preview https://deploy-preview-6500--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot requested review from feloy and rm3l January 17, 2023 16:47
@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

OpenShift Tests on commit b0ec29d finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

NoCluster Tests on commit b0ec29d finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

Unit Tests on commit b0ec29d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

Validate Tests on commit b0ec29d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

Kubernetes Tests on commit b0ec29d finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

Windows Tests (OCP) on commit b0ec29d finished with errors.
View logs: TXT HTML

@rm3l rm3l added this to the v3.6.0 🚀 milestone Jan 18, 2023
feloy
feloy reviewed Jan 25, 2023
View reviewed changes
docs/website/blog/2023-02-01-odo-dotnet-postgresql-openshift.mdx Outdated



Now, refresh the local URL [http://localhost:40001](http://localhost:40001). You should see that our application is using the PostgreSQL database.
Copy link
Contributor

@feloy feloy Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Now, refresh the local URL [http://localhost:40001](http://localhost:40001). You should see that our application is using the PostgreSQL database.
Now, refresh the local URL [http://localhost:20001](http://localhost:20001). You should see that our application is using the PostgreSQL database.

rm3l
rm3l requested changes Jan 30, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tutorial. I added a few comments and suggestions.

@rm3l rm3l modified the milestones: v3.6.0 🚀, v3.7.0 🚀 Feb 6, 2023
@kadel kadel force-pushed the s2i-openshift-example branch from 744805e to b8ebeba Compare February 10, 2023 17:20
@kadel kadel changed the title [WIP] blog: odo with .NET and PostgreSQL on OpenShift blog: odo with .NET and PostgreSQL on OpenShift Feb 10, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Feb 10, 2023
rm3l
rm3l requested changes Feb 14, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found 2 minor typos to fix, but LGTM overall.

@rm3l rm3l modified the milestones: v3.7.0 🚀, v3.8.0 🚀 Feb 21, 2023
@kadel
Copy link
Member Author

kadel commented Feb 22, 2023

updated, now it should be ready for publishing.
Thx, @feloy and @rm3l for reviews

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 22, 2023
@rm3l rm3l mentioned this pull request Feb 22, 2023
Closed
@rm3l
Copy link
Member

rm3l commented Feb 22, 2023 •
edited
Loading

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override NoCluster-Integration-tests/NoCluster-Integration-tests
/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests
/override windows-integration-test/Windows-test

Overriding because this is a doc-only PR. It was still interesting to see why all those tests failed.
They seem to have failed because of the update notification being displayed in the odo output. Some of the tests are currently making strict assertions on the output. The issue has been reported in #6618

@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2023

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, NoCluster-Integration-tests/NoCluster-Integration-tests, OpenShift-Integration-tests/OpenShift-Integration-tests, OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests, windows-integration-test/Windows-test

Details

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override NoCluster-Integration-tests/NoCluster-Integration-tests
/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests
/override windows-integration-test/Windows-test

Overriding because this is a doc-only PR. It was still interesting to see why all those tests failed.
They seem to have failed because of the update notification between displayed in the odo output. Some of the tests are currently making strict assertions on the output. The issue has been reported in #6618

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e60a502 into redhat-developer:main Feb 22, 2023
anandrkskd pushed a commit to anandrkskd/odo that referenced this pull request Mar 7, 2023
@kadel @rm3l @anandrkskd
blog: odo with .NET and PostgreSQL on OpenShift (redhat-developer#6500)
677c7c7 
* blog: odo with .NET and PostgreSQL on OpenShift

* address reviews

* Update docs/website/blog/2023-02-17-odo-dotnet-postgresql-openshift.mdx

Co-authored-by: Armel Soro <[email protected]>

* Update docs/website/blog/2023-02-17-odo-dotnet-postgresql-openshift.mdx

Co-authored-by: Armel Soro <[email protected]>

---------

Co-authored-by: Armel Soro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l requested changes

+1 more reviewer

@feloy feloy feloy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rm3l rm3l

@feloy feloy

Labels

area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

v3.8.0 🚀

Development

Successfully merging this pull request may close these issues.

4 participants

@kadel @rm3l @feloy @openshift-merge-robot