Skip to content

Change port range used for port-forwarding endpoints to start at 20001#6519

Merged
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
feloy:feature-6483/port-20000
Jan 23, 2023
Merged

Change port range used for port-forwarding endpoints to start at 20001#6519
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
feloy:feature-6483/port-20000

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Jan 20, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6483

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 068b120
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63cea2351aa04e000ab0caf6
😎 Deploy Preview https://deploy-preview-6519--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jan 20, 2023
@feloy feloy requested review from rm3l and valaparthvi January 20, 2023 15:10
@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023

NoCluster Tests on commit 1dd4ae5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023

OpenShift Unauthenticated Tests on commit 1dd4ae5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023

Unit Tests on commit e6d608a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023

Validate Tests on commit e6d608a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023

Kubernetes Tests on commit e6d608a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023

Windows Tests (OCP) on commit 1dd4ae5 finished successfully.
View logs: TXT HTML

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I just tested that it (Che's automatic exposure of ports) worked as expected when using odo from within Dev Spaces:

image

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 23, 2023
@feloy feloy closed this Jan 23, 2023
@feloy feloy reopened this Jan 23, 2023
@feloy feloy force-pushed the feature-6483/port-20000 branch from 6485a35 to 068b120 Compare January 23, 2023 15:05
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2023

New changes are detected. LGTM label has been removed.

@rm3l rm3l added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 23, 2023
@rm3l rm3l closed this Jan 23, 2023
@rm3l rm3l reopened this Jan 23, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-merge-robot openshift-merge-robot merged commit d2443d0 into redhat-developer:main Jan 23, 2023
rm3l added a commit to rm3l/odo that referenced this pull request Feb 3, 2023
openshift-merge-robot pushed a commit that referenced this pull request Feb 3, 2023
* Fix the port value (20001) in the quickstart guides

#6519 has updated the port range to start at 20001

* Clarify that users should wait until 'odo dev' displays 'Forwarding from ...' before trying to reach the application
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change port range used for port-forwarding endpoints

3 participants