Skip to content

Show information about forwarded debug ports in odo describe component#6537

Merged
openshift-merge-robot merged 7 commits intoredhat-developer:mainfrom
rm3l:6036-odo-describe-component-should-show-information-about-available-debug-ports
Jan 27, 2023
Merged

Show information about forwarded debug ports in odo describe component#6537
openshift-merge-robot merged 7 commits intoredhat-developer:mainfrom
rm3l:6036-odo-describe-component-should-show-information-about-available-debug-ports

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Jan 25, 2023 •
edited
Loading

What type of PR is this:
/kind feature

What does this PR do / why we need it:
This adds information about the port name and exposure to the odo describe component output, for each forwarded port displayed.
See #6036 for more details.

Which issue(s) this PR fixes:
Fixes #6036

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jan 25, 2023
@netlify
Copy link

netlify bot commented Jan 25, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 5036b4f
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63d254b4524406000882ed45
😎 Deploy Preview https://deploy-preview-6537--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Jan 25, 2023 •
edited
Loading

OpenShift Tests on commit a3d9cf4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 25, 2023 •
edited
Loading

NoCluster Tests on commit a3d9cf4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 25, 2023 •
edited
Loading

Validate Tests on commit a3d9cf4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 25, 2023 •
edited
Loading

Windows Tests (OCP) on commit a3d9cf4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 25, 2023 •
edited
Loading

Kubernetes Tests on commit a3d9cf4 finished with errors.
View logs: TXT HTML

@rm3l rm3l force-pushed the 6036-odo-describe-component-should-show-information-about-available-debug-ports branch from b7d0740 to 5036b4f Compare January 26, 2023 10:23
@odo-robot
Copy link

odo-robot bot commented Jan 26, 2023 •
edited
Loading

Unit Tests on commit a3d9cf4 finished successfully.
View logs: TXT HTML

@rm3l rm3l changed the title [WIP] Show information about forwarded debug ports in odo describe component Show information about forwarded debug ports in odo describe component Jan 26, 2023
@rm3l rm3l marked this pull request as ready for review January 26, 2023 10:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 26, 2023
@openshift-ci openshift-ci bot requested review from feloy and kadel January 26, 2023 10:55
@rm3l rm3l requested review from valaparthvi and removed request for kadel January 26, 2023 10:55
feloy
feloy approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work @rm3l

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 26, 2023
@rm3l rm3l closed this Jan 26, 2023
@rm3l rm3l reopened this Jan 26, 2023
@rm3l rm3l closed this Jan 26, 2023
@rm3l rm3l reopened this Jan 26, 2023
@rm3l rm3l closed this Jan 26, 2023
@rm3l rm3l reopened this Jan 26, 2023
@rm3l rm3l closed this Jan 27, 2023
@rm3l rm3l reopened this Jan 27, 2023
@rm3l rm3l closed this Jan 27, 2023
@rm3l rm3l reopened this Jan 27, 2023
@feloy feloy closed this Jan 27, 2023
@feloy feloy reopened this Jan 27, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy
Copy link
Contributor

feloy commented Jan 27, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
Flaky test fixed by #6543

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

Details

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
Flaky test fixed by #6543

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Jan 27, 2023

/override ci/prow/v4.11-integration-e2e
Previoously passed

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

Details

In response to this:

/override ci/prow/v4.11-integration-e2e
Previoously passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Jan 27, 2023

/override odo-podman-test / ODO-PODMAN-TEST
Previously passed

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • /
  • ODO-PODMAN-TEST
  • odo-podman-test

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests
  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • NoCluster-Integration-tests/NoCluster-Integration-tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/unit-and-validate-test
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.11-integration-e2e
  • ci/prow/v4.12-images
  • ci/prow/v4.9-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-unit-and-validate-test
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.11-integration-e2e
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.9-images
  • tide
  • validator/Validate
  • windows-integration-test/Windows-test

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override odo-podman-test / ODO-PODMAN-TEST
Previously passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Jan 27, 2023

/override "odo-podman-test / ODO-PODMAN-TEST"

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • odo-podman-test / ODO-PODMAN-TEST

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests
  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • NoCluster-Integration-tests/NoCluster-Integration-tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/unit-and-validate-test
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.11-integration-e2e
  • ci/prow/v4.12-images
  • ci/prow/v4.9-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-unit-and-validate-test
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.11-integration-e2e
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.9-images
  • tide
  • validator/Validate
  • windows-integration-test/Windows-test

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override "odo-podman-test / ODO-PODMAN-TEST"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 9a39462 into redhat-developer:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

1 more reviewer

@feloy feloy feloy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@feloy feloy

Labels

kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

odo describe component should show information about available debug ports

3 participants

@rm3l @feloy @openshift-merge-robot