Skip to content

[WIP] Display Pod is Running before syncing files#6545

Closed
feloy wants to merge 4 commits intoredhat-developer:mainfrom
feloy:bugfix/display-pod-running-before-sync
Closed

[WIP] Display Pod is Running before syncing files#6545
feloy wants to merge 4 commits intoredhat-developer:mainfrom
feloy:bugfix/display-pod-running-before-sync

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Jan 27, 2023 •
edited
Loading

What type of PR is this:

/kind tests

What does this PR do / why we need it:

During tests, Pod is Running is regularly displayed after syncing files:

  Expected
      <string>:   (
        	"""
        	... // 9 identical lines
        	•  Waiting for Kubernetes resources  ...
        	⚠  Pod is Pending
      - 	✓  Pod is Running
        	✓  Syncing files into the container [1s]
        	✓  Building your application in container (command: install) [1s]
        	... // 9 identical lines
        	[Ctrl+c] - Exit and delete resources from the cluster
        	[p] - Manually apply local changes to the application on the cluster
      + 	✓  Pod is Running
        	```
        	"""
        )
      
  to be empty

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jan 27, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 949ebab
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63da13a384889c000894a818

@openshift-ci openshift-ci bot requested review from anandrkskd and kadel January 27, 2023 13:44
@feloy feloy requested review from rm3l and valaparthvi and removed request for anandrkskd and kadel January 27, 2023 13:45
@odo-robot
Copy link

odo-robot bot commented Jan 27, 2023 •
edited
Loading

OpenShift Tests on commit c90d71f finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 27, 2023 •
edited
Loading

NoCluster Tests on commit c90d71f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 27, 2023 •
edited
Loading

Unit Tests on commit c90d71f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 27, 2023 •
edited
Loading

Kubernetes Docs Tests on commit e0ab28c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 27, 2023 •
edited
Loading

Validate Tests on commit c90d71f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 27, 2023 •
edited
Loading

Windows Tests (OCP) on commit c90d71f finished with errors.
View logs: TXT HTML

@feloy feloy closed this Jan 27, 2023
@feloy feloy reopened this Jan 27, 2023
@feloy feloy force-pushed the bugfix/display-pod-running-before-sync branch from f817c60 to ab3940e Compare January 27, 2023 18:32
@odo-robot
Copy link

odo-robot bot commented Jan 27, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit c90d71f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 27, 2023 •
edited
Loading

Kubernetes Tests on commit c90d71f finished successfully.
View logs: TXT HTML

@feloy feloy mentioned this pull request Jan 28, 2023
Merged
3 tasks
@feloy feloy force-pushed the bugfix/display-pod-running-before-sync branch from ab3940e to 1415fb2 Compare January 28, 2023 16:34
@feloy
Copy link
Contributor Author

feloy commented Jan 28, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jan 28, 2023
@feloy feloy force-pushed the bugfix/display-pod-running-before-sync branch from 1415fb2 to 5e5e0d2 Compare January 31, 2023 14:57
@feloy feloy closed this Jan 31, 2023
@feloy feloy reopened this Jan 31, 2023
@feloy feloy force-pushed the bugfix/display-pod-running-before-sync branch from d9e2d3b to 140f623 Compare February 1, 2023 07:20
@feloy feloy closed this Feb 1, 2023
@feloy feloy reopened this Feb 1, 2023
@feloy feloy closed this Feb 1, 2023
@feloy feloy reopened this Feb 1, 2023
@feloy feloy closed this Feb 1, 2023
@feloy feloy reopened this Feb 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy
Copy link
Contributor Author

feloy commented Feb 1, 2023

/hold
As raised by @rm3l , it is not working correctly when a pod terminates.

Also, I need to find a way to fix it using the existing synchronization tools, not adding a new one

@feloy feloy changed the title Display Pod is Running before syncing files [WIP] Display Pod is Running before syncing files Feb 1, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Feb 1, 2023
@kadel kadel added area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering and removed kind/tests labels Feb 6, 2023
@openshift-ci openshift-ci bot mentioned this pull request Feb 14, 2023
Merged
This was referenced Mar 2, 2023
Merged
Merged
Merged
@rm3l rm3l mentioned this pull request Mar 15, 2023
Merged
3 tasks
@rm3l rm3l mentioned this pull request Apr 3, 2023
Merged
3 tasks
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Apr 25, 2023
@openshift-merge-robot
Copy link
Collaborator

openshift-merge-robot commented Apr 25, 2023

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l mentioned this pull request May 1, 2023
Merged
@openshift-ci
Copy link

openshift-ci bot commented May 26, 2023

@feloy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odo-ocp4.13-lp-interop-images 949ebab link true /test odo-ocp4.13-lp-interop-images
ci/prow/odo-ocp4.14-lp-interop-images 949ebab link true /test odo-ocp4.14-lp-interop-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feloy feloy closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

@rm3l rm3l Awaiting requested review from rm3l

Assignees

No one assigned

Labels

area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@feloy @openshift-merge-robot @kadel