Skip to content

Bump Go to 1.19#6586

Merged
openshift-merge-robot merged 6 commits intoredhat-developer:mainfrom
rm3l:6581-use-go-1.19
Feb 16, 2023
Merged

Bump Go to 1.19#6586
openshift-merge-robot merged 6 commits intoredhat-developer:mainfrom
rm3l:6581-use-go-1.19

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Feb 9, 2023

What type of PR is this:
/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #6581

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Feb 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 9, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Feb 9, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 4c0c852
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63edfc7a04561a0009a6f014

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Feb 9, 2023
@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023 •
edited
Loading

NoCluster Tests on commit 3e2903d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 3e2903d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023 •
edited
Loading

Unit Tests on commit 3e2903d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023 •
edited
Loading

Validate Tests on commit 3e2903d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023 •
edited
Loading

Kubernetes Tests on commit 3e2903d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023 •
edited
Loading

Windows Tests (OCP) on commit 3e2903d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023 •
edited
Loading

OpenShift Tests on commit 3e2903d finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 262d11e finished successfully.
View logs: TXT HTML

@rm3l rm3l mentioned this pull request Feb 9, 2023
Merged
3 tasks
@rm3l rm3l changed the title [WIP] Bump Go to 1.19 Bump Go to 1.19 Feb 9, 2023
@rm3l
Copy link
Member Author

rm3l commented Feb 9, 2023 •
edited
Loading

/hold

For several reasons:

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Feb 9, 2023
@rm3l rm3l marked this pull request as ready for review February 9, 2023 14:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Feb 9, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and feloy February 9, 2023 14:31
@rm3l rm3l requested review from kadel and valaparthvi February 9, 2023 14:32
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 13, 2023
rm3l added 5 commits February 16, 2023 10:49
@rm3l
Set Go version in go.mod
1981d22 
go mod edit -go=1.19
@rm3l
Fix formatting issues reported by gofmt
3f26a89
@rm3l
Fix SA1019 check (usage of deprecated "io/ioutil"), reported by golan…
48944ab 
…gci-lint

SA1019: "io/ioutil" has been deprecated since Go 1.16:
As of Go 1.16, the same functionality is now provided by package io or package os,
and those implementations should be preferred in new code.
See the specific function documentation for details. (staticcheck)
@rm3l
Use Go 1.19 in our Dockerfiles
0efad5d
@rm3l
Use Go 1.19 in the rpm-prepare.sh script
b2d006c
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 16, 2023
@rm3l
Copy link
Member Author

rm3l commented Feb 16, 2023

/hold cancel

Removing the hold, since CWFCONF-3455 has been resolved and I've checked that Golang 1.19 was available internally.
Also rebased to test that the IBM Cloud image builds successfully (#6587).

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Feb 16, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l requested a review from feloy February 16, 2023 09:52
@rm3l
Copy link
Member Author

rm3l commented Feb 16, 2023 

Timed out after 180.001s.
  Expected
      <string>:  ⚠  Pod is Terminating
       ✗  Finished executing the application (command: devrun) [40s]
       ⚠  No pod exists
       ⚠  Pod is Pending
       ✓  Pod is Running
       •  Syncing files into the container  ...
      
 ✓  Syncing files into the container [382ms]
       •  Building your application in container (command: devbuild)  ...
      
 ✓  Building your application in container (command: devbuild) [6s]
       •  Executing the application (command: devrun)  ...
       -  Forwarding from 127.0.0.1:42585 -> 3000
      
      ↪ Dev mode
       Keyboard Commands:
      [Ctrl+c] - Exit and delete resources from the cluster
           [p] - Manually apply local changes to the application on the cluster
      
  To satisfy at least one of these matchers: [%!s(*matchers.ContainSubstringMatcher=&{Pushing files... []}) %!s(*matchers.ContainSubstringMatcher=&{Updating Component... []})]
  In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:64
------------------------------
Summarizing 1 Failure:
  [FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [BeforeEach] should react on the Devfile modification
  /go/odo_1/tests/helper/helper_run.go:64

Ran 421 of 771 Specs in 1277.997 seconds
FAIL! -- 420 Passed | 1 Failed | 0 Pending | 350 Skipped

Flaky test.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

Timed out after 180.001s.
 Expected
     <string>:  ⚠  Pod is Terminating
      ✗  Finished executing the application (command: devrun) [40s]
      ⚠  No pod exists
      ⚠  Pod is Pending
      ✓  Pod is Running
      •  Syncing files into the container  ...
     
✓  Syncing files into the container [382ms]
      •  Building your application in container (command: devbuild)  ...
     
✓  Building your application in container (command: devbuild) [6s]
      •  Executing the application (command: devrun)  ...
      -  Forwarding from 127.0.0.1:42585 -> 3000
     
     ↪ Dev mode
      Keyboard Commands:
     [Ctrl+c] - Exit and delete resources from the cluster
          [p] - Manually apply local changes to the application on the cluster
     
 To satisfy at least one of these matchers: [%!s(*matchers.ContainSubstringMatcher=&{Pushing files... []}) %!s(*matchers.ContainSubstringMatcher=&{Updating Component... []})]
 In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:64
------------------------------
Summarizing 1 Failure:
 [FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [BeforeEach] should react on the Devfile modification
 /go/odo_1/tests/helper/helper_run.go:64

Ran 421 of 771 Specs in 1277.997 seconds
FAIL! -- 420 Passed | 1 Failed | 0 Pending | 350 Skipped

Flaky test.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l mentioned this pull request Feb 16, 2023
Closed
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 16, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7b9f214 into redhat-developer:main Feb 16, 2023
@rm3l rm3l deleted the 6581-use-go-1.19 branch February 16, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@kadel kadel Awaiting requested review from kadel

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

1 more reviewer

@feloy feloy feloy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@feloy feloy

Labels

kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use Go 1.20 (or 1.19)

3 participants

@rm3l @feloy @openshift-merge-robot