Skip to content

Allow : character in devfile registry URI#6624

Merged
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
feloy:bugfix-6623/colon-in-url
Feb 27, 2023
Merged

Allow : character in devfile registry URI#6624
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
feloy:bugfix-6623/colon-in-url

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Feb 27, 2023

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6623

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Feb 27, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit de12abe
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63fcb6b73c026a0008ba28c2

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 27, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and kadel February 27, 2023 13:36
@odo-robot
Copy link

odo-robot bot commented Feb 27, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 1ab2a1c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 27, 2023 •
edited
Loading

NoCluster Tests on commit 1ab2a1c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 27, 2023 •
edited
Loading

Unit Tests on commit 1ab2a1c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 27, 2023 •
edited
Loading

Validate Tests on commit 1ab2a1c finished successfully.
View logs: TXT HTML

@feloy feloy requested review from rm3l and removed request for anandrkskd and kadel February 27, 2023 13:55
@feloy feloy force-pushed the bugfix-6623/colon-in-url branch from b472404 to de12abe Compare February 27, 2023 13:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Feb 27, 2023 •
edited
Loading

Kubernetes Tests on commit 1ab2a1c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 27, 2023 •
edited
Loading

Windows Tests (OCP) on commit 1ab2a1c finished successfully.
View logs: TXT HTML

rm3l
rm3l approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 27, 2023
@odo-robot
Copy link

odo-robot bot commented Feb 27, 2023 •
edited
Loading

OpenShift Tests on commit 1ab2a1c finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 27, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 99bdaeb finished with errors.
View logs: TXT HTML

@feloy
Copy link
Contributor Author

feloy commented Feb 27, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

        	... // 9 identical lines
        	•  Waiting for Kubernetes resources  ...
        	âš   Pod is Pending
      - 	✓  Pod is Running
        	✓  Syncing files into the container [1s]
        	✓  Building your application in container (command: build) [1s]
        	... // 9 identical lines
        	[Ctrl+c] - Exit and delete resources from the cluster
        	[p] - Manually apply local changes to the application on the cluster
      + 	✓  Pod is Running
        	```

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2023

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

Details

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

       	... // 9 identical lines
       	•  Waiting for Kubernetes resources  ...
       	âš   Pod is Pending
     - 	✓  Pod is Running
       	✓  Syncing files into the container [1s]
       	✓  Building your application in container (command: build) [1s]
       	... // 9 identical lines
       	[Ctrl+c] - Exit and delete resources from the cluster
       	[p] - Manually apply local changes to the application on the cluster
     + 	✓  Pod is Running
       	```

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Feb 27, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Flaky test

odo dev command tests
/go/odo_1/tests/integration/cmd_dev_test.go:33
  port-forwarding for the component
  /go/odo_1/tests/integration/cmd_dev_test.go:658
    when devfile has single endpoint
    /go/odo_1/tests/integration/cmd_dev_test.go:695
      when running odo dev
      /go/odo_1/tests/integration/cmd_dev_test.go:704
        when modifying memoryLimit for container in Devfile [BeforeEach]
        /go/odo_1/tests/integration/cmd_dev_test.go:739
          should react on the Devfile modification
          /go/odo_1/tests/integration/cmd_dev_test.go:759

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Flaky test

odo dev command tests
/go/odo_1/tests/integration/cmd_dev_test.go:33
 port-forwarding for the component
 /go/odo_1/tests/integration/cmd_dev_test.go:658
   when devfile has single endpoint
   /go/odo_1/tests/integration/cmd_dev_test.go:695
     when running odo dev
     /go/odo_1/tests/integration/cmd_dev_test.go:704
       when modifying memoryLimit for container in Devfile [BeforeEach]
       /go/odo_1/tests/integration/cmd_dev_test.go:739
         should react on the Devfile modification
         /go/odo_1/tests/integration/cmd_dev_test.go:759

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Feb 27, 2023

/retest

@rm3l
Copy link
Member

rm3l commented Feb 27, 2023

/test v4.9-images
/test v4.10-images
/test v4.11-images
/test v4.12-images

@feloy
Copy link
Contributor Author

feloy commented Feb 27, 2023

/override v4.9-images
/override v4.10-images
/override v4.11-images
/override v4.12-images

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2023

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • v4.10-images
  • v4.11-images
  • v4.12-images
  • v4.9-images

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests
  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.12-images
  • ci/prow/v4.9-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.9-images
  • tide
  • validator/Validate

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override v4.9-images
/override v4.10-images
/override v4.11-images
/override v4.12-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Feb 27, 2023

/override ci/prowv4.9-images
/override ci/prowv4.10-images
/override ci/prowv4.11-images
/override ci/prowv4.12-images

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2023

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prowv4.10-images
  • ci/prowv4.11-images
  • ci/prowv4.12-images
  • ci/prowv4.9-images

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests
  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.12-images
  • ci/prow/v4.9-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.9-images
  • tide
  • validator/Validate

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ci/prowv4.9-images
/override ci/prowv4.10-images
/override ci/prowv4.11-images
/override ci/prowv4.12-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Feb 27, 2023

/override ci/prow/v4.9-images
/override ci/prow/v4.10-images
/override ci/prow/v4.11-images
/override ci/prow/v4.12-images

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2023

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-images, ci/prow/v4.11-images, ci/prow/v4.12-images, ci/prow/v4.9-images

Details

In response to this:

/override ci/prow/v4.9-images
/override ci/prow/v4.10-images
/override ci/prow/v4.11-images
/override ci/prow/v4.12-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 99d6450 into redhat-developer:main Feb 27, 2023
anandrkskd pushed a commit to anandrkskd/odo that referenced this pull request Mar 7, 2023
@feloy @anandrkskd
Allow : character in devfile registry URI (redhat-developer#6624)
4ddb19f 
* Allow `:` character in devfile registry URI

* Add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels

kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding a registry with a port in the URI fails

3 participants

@feloy @rm3l @openshift-merge-robot