Skip to content

Document air-gapped env#6627

Merged
openshift-merge-robot merged 3 commits intoredhat-developer:mainfrom
feloy:doc-6542/air-gap-env
Mar 3, 2023
Merged

Document air-gapped env#6627
openshift-merge-robot merged 3 commits intoredhat-developer:mainfrom
feloy:doc-6542/air-gap-env

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Feb 28, 2023 •
edited
Loading

What type of PR is this:

/area documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6542

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Preview: https://deploy-preview-6627--odo-docusaurus-preview.netlify.app/docs/user-guides/advanced/container-based-application-development-air-gapped-environment

@netlify
Copy link

netlify bot commented Feb 28, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit f423ed0
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/640202f3ff276000083d4d6f
😎 Deploy Preview https://deploy-preview-6627--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added the area/documentation Issues or PRs related to documentation or the 'odo.dev' website label Feb 28, 2023
@openshift-ci openshift-ci bot requested review from kadel and rm3l February 28, 2023 13:42
@feloy feloy requested review from valaparthvi and removed request for kadel February 28, 2023 13:42
@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 6ea7e7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

NoCluster Tests on commit 6ea7e7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

Unit Tests on commit 6ea7e7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

Validate Tests on commit 6ea7e7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

Kubernetes Tests on commit 6ea7e7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

Windows Tests (OCP) on commit 6ea7e7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

OpenShift Tests on commit 6ea7e7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 775adfd finished successfully.
View logs: TXT HTML

rm3l
rm3l requested changes Mar 3, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.

Also, I guess in such air-gapped environments, even the cluster control plane might not be reachable from outside the isolated network. It might not be that clear, so I thought we may want to also mention that odo needs to be run from a place where it has access to the air-gapped cluster API server.

@feloy feloy requested a review from rm3l March 3, 2023 12:02
@feloy
Copy link
Contributor Author

feloy commented Mar 3, 2023

Also, I guess in such air-gapped environments, even the cluster control plane might not be reachable from outside the isolated network. It might not be that clear, so I thought we may want to also mention that odo needs to be run from a place where it has access to the air-gapped cluster API server.

Good catch. I have added a section about this.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rm3l
rm3l approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 8b4ccf5 into redhat-developer:main Mar 3, 2023
anandrkskd pushed a commit to anandrkskd/odo that referenced this pull request Mar 7, 2023
@feloy @rm3l @anandrkskd
Document air-gapped env (redhat-developer#6627)
2dd3b34 
* Document air-gapped env

* Apply suggestions from code review

Co-authored-by: Armel Soro <[email protected]>

* Add section about using HTTPS_PROXY with cluster

---------

Co-authored-by: Armel Soro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels

area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document potential pitfalls with air-gapped environments

3 participants

@feloy @rm3l @openshift-merge-robot