Skip to content

Ignore errors that might happen when getting Devfile Registries from the cluster#6639

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
rm3l:6636-odo-fails-to-fetch-devfiles-when-disconnected-from-the-cluster
Mar 7, 2023
Merged

Ignore errors that might happen when getting Devfile Registries from the cluster#6639
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
rm3l:6636-odo-fails-to-fetch-devfiles-when-disconnected-from-the-cluster

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Mar 7, 2023

What type of PR is this:
/kind bug
/area registry

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #6636

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Mar 7, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 0b196df
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64070bc0b6ea2a00071298ad

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/registry Issues or PRs related to Devfile registries labels Mar 7, 2023
@openshift-ci openshift-ci bot requested review from kadel and valaparthvi March 7, 2023 10:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@rm3l rm3l requested review from feloy and removed request for kadel March 7, 2023 10:20
@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

OpenShift Tests on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

Kubernetes Docs Tests on commit ef6489c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

valaparthvi
valaparthvi approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. I was going to suggest adding a test case for this, but I see we already have the test cases but I am surprised they did not catch the error.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 7, 2023
@rm3l
Copy link
Member Author

rm3l commented Mar 7, 2023

Thank you for fixing this. I was going to suggest adding a test case for this, but I see we already have the test cases but I am surprised they did not catch the error.

The code actually works (and is tested) when the user is not logged into the cluster or when not using any cluster at all..
I don't think we have test cases for clusters that might not be reachable at all (as was the case in #6636). We have test cases for either no-cluster or unauthenticated (but still reachable).
That's why this PR is ignoring any errors returned while trying to get the list of registries from the cluster, and this should be covered by unit tests.

@feloy
Copy link
Contributor

feloy commented Mar 7, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test
Known flaky tests

@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests, windows-integration-test/Windows-test

Details

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test
Known flaky tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit f001676 into redhat-developer:main Mar 7, 2023
@rm3l rm3l deleted the 6636-odo-fails-to-fetch-devfiles-when-disconnected-from-the-cluster branch March 7, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feloy feloy Awaiting requested review from feloy

1 more reviewer

@valaparthvi valaparthvi valaparthvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@valaparthvi valaparthvi

Labels

area/registry Issues or PRs related to Devfile registries kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

odo fails to fetch devfiles when disconnected from the cluster

4 participants

@rm3l @feloy @valaparthvi @openshift-merge-robot