Skip to content

Skip DevfileRegistriesList-related tests on non Kubernetes clusters#6640

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
rm3l:6637-nightly-failure-devfileregistrieslist-tests-failing-on-prow
Mar 7, 2023
Merged

Skip DevfileRegistriesList-related tests on non Kubernetes clusters#6640
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
rm3l:6637-nightly-failure-devfileregistrieslist-tests-failing-on-prow

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Mar 7, 2023

What type of PR is this:
/kind bug
/area testing

What does this PR do / why we need it:
On Prow, users do not seem to have permission to install the DevfileRegistriesList Custom Resource Definition.

Which issue(s) this PR fixes:
Fixes #6637

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
On an OpenShift cluster (with the oc client available in the PATH), this should pass:

unset KUBERNETES && make test-integration-cluster

@rm3l
Skip DevfileRegistriesList-related tests on non Kubernetes clusters
b3327fd 
On Prow, users might not have the permission to install the CRDs.
It is actually fine to execute these tests only on Kubernetes.
@netlify
Copy link

netlify bot commented Mar 7, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit b3327fd
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/640749ef8504880007c3f7fc

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels Mar 7, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and feloy March 7, 2023 14:28
@rm3l rm3l requested a review from ritudes March 7, 2023 14:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@rm3l rm3l mentioned this pull request Mar 7, 2023
Closed
@anandrkskd
Copy link
Contributor

anandrkskd commented Mar 7, 2023

I will LGTM it as soon as the tests passes

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

Kubernetes Docs Tests on commit f001676 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 7, 2023

OpenShift Tests on commit finished with errors.
View logs: TXT HTML

@rm3l
Copy link
Member Author

rm3l commented Mar 7, 2023 

  Expected
      <*url.Error | 0xc0005f04e0>: {
          Op: "Post",
          URL: "http://127.0.0.1:33651/api/newuser",
          Err: <*errors.errorString | 0xc000070130>{s: "EOF"},
      }
  to be nil
  In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:306

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  /go/odo_1/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 180.157 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test - reported in #6582

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

 Expected
     <*url.Error | 0xc0005f04e0>: {
         Op: "Post",
         URL: "http://127.0.0.1:33651/api/newuser",
         Err: <*errors.errorString | 0xc000070130>{s: "EOF"},
     }
 to be nil
 In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:306

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 /go/odo_1/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 180.157 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test - reported in #6582

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anandrkskd
Copy link
Contributor

anandrkskd commented Mar 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 7, 2023
@anandrkskd
Copy link
Contributor

anandrkskd commented Mar 7, 2023

/approve

@openshift-merge-robot openshift-merge-robot merged commit b3bc7c4 into redhat-developer:main Mar 7, 2023
@rm3l rm3l deleted the 6637-nightly-failure-devfileregistrieslist-tests-failing-on-prow branch March 7, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@feloy feloy Awaiting requested review from feloy

@ritudes ritudes Awaiting requested review from ritudes

Assignees

@anandrkskd anandrkskd

Labels

area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Nightly failure] DevfileRegistriesList tests failing on prow

3 participants

@rm3l @anandrkskd @openshift-merge-robot