Fix potential issue with `odo describe component` integration tests when Podman is installed by rm3l · Pull Request #6642 · redhat-developer/odo

rm3l · 2023-03-08T09:22:26Z

What type of PR is this:
/kind bug
/area testing

What does this PR do / why we need it:

content of path "message" should contain "no component found with name \"unknown-name\" in the namespace \"cmd-describe-component-test70ezo\"" but is "no component found with name \"unknown-name\""
Expected
    <string>: no component found with name "unknown-name"
to contain substring
    <string>: no component found with name "unknown-name" in the namespace "cmd-describe-component-test70ezo"

I noticed this error message when running the following integration tests locally:

odo describe component command tests when creating a component [It] should not describe the component from another directory
odo describe component command tests [It] should fail, with cluster

odo describe component tries to describe the component on both Podman (if available) and cluster. Because I have Podman installed locally, the error message is not actually the one expected in the tests.
When running locally with Podman installed, the error message no longer contains the reference to the namespace.

Which issue(s) this PR fixes:
—

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:
With the Podman binary installed locally, the tests mentioned above should now pass with the changes here.

…hen Podman is installed When running locally with Podman installed, the error message no longer contains the reference to the namespace.

netlify · 2023-03-08T09:22:32Z

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	`91b2808`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/640853d40348d00008d42157

sonarqubecloud · 2023-03-08T09:27:18Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

odo-robot · 2023-03-08T09:32:50Z

OpenShift Unauthenticated Tests on commit 2aca0a6 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-08T09:33:25Z

NoCluster Tests on commit 2aca0a6 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-08T09:34:25Z

Unit Tests on commit 2aca0a6 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-08T09:43:59Z

Validate Tests on commit 2aca0a6 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-08T09:50:38Z

Kubernetes Tests on commit 2aca0a6 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-08T09:52:41Z

OpenShift Tests on commit 2aca0a6 finished with errors.
View logs: TXT HTML

odo-robot · 2023-03-08T09:54:30Z

Windows Tests (OCP) on commit 2aca0a6 finished with errors.
View logs: TXT HTML

odo-robot · 2023-03-08T10:00:42Z

Kubernetes Docs Tests on commit 9c592c4 finished successfully.
View logs: TXT HTML

tests/integration/cmd_describe_component_test.go

rm3l · 2023-03-08T13:02:26Z

Summarizing 1 Failure:
  [FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [BeforeEach] should react on the Devfile modification
  /go/odo_1/tests/helper/helper_run.go:64

Ran 429 of 779 Specs in 1223.965 seconds
FAIL! -- 428 Passed | 1 Failed | 0 Pending | 350 Skipped

Flaky test - reported in #6601

/override OpenShift-Integration-tests/OpenShift-Integration-tests

openshift-ci · 2023-03-08T13:02:31Z

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

Summarizing 1 Failure:
 [FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [BeforeEach] should react on the Devfile modification
 /go/odo_1/tests/helper/helper_run.go:64

Ran 429 of 779 Specs in 1223.965 seconds
FAIL! -- 428 Passed | 1 Failed | 0 Pending | 350 Skipped

Flaky test - reported in #6601

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rm3l · 2023-03-08T13:03:33Z

  Expected
      <*url.Error | 0xc000450000>: {
          Op: "Post",
          URL: "http://127.0.0.1:59998/api/newuser",
          Err: <*errors.errorString | 0xc00007c130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3384/tests/e2escenarios/e2e_test.go:306

  There were additional failures detected after the initial failure.  Here's a summary - for full details run Ginkgo in verbose mode:
    [FAILED] in [AfterEach] at C:/Users/Administrator.ANSIBLE-TEST-VS/3384/tests/helper/helper_filesystem.go:48
------------------------------

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3384/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 208.687 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test - reported in #6582

/override windows-integration-test/Windows-test

openshift-ci · 2023-03-08T13:03:38Z

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

Details

In response to this:

 Expected
     <*url.Error | 0xc000450000>: {
         Op: "Post",
         URL: "http://127.0.0.1:59998/api/newuser",
         Err: <*errors.errorString | 0xc00007c130>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3384/tests/e2escenarios/e2e_test.go:306

 There were additional failures detected after the initial failure.  Here's a summary - for full details run Ginkgo in verbose mode:
   [FAILED] in [AfterEach] at C:/Users/Administrator.ANSIBLE-TEST-VS/3384/tests/helper/helper_filesystem.go:48
------------------------------

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 C:/Users/Administrator.ANSIBLE-TEST-VS/3384/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 208.687 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test - reported in #6582

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fix potential issue with 'odo describe component' integration tests w…

91b2808

…hen Podman is installed When running locally with Podman installed, the error message no longer contains the reference to the namespace.

openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels Mar 8, 2023

openshift-ci bot requested review from anandrkskd and valaparthvi March 8, 2023 09:22

rm3l requested a review from ritudes March 8, 2023 09:23

rm3l added this to the v3.9.0 🚀 milestone Mar 8, 2023

rm3l changed the title ~~Fix potential issue with 'odo describe component' integration tests when Podman is installed~~ Fix potential issue with odo describe component integration tests when Podman is installed Mar 8, 2023

rm3l closed this Mar 8, 2023

rm3l reopened this Mar 8, 2023

valaparthvi approved these changes Mar 8, 2023

View reviewed changes

tests/integration/cmd_describe_component_test.go Show resolved Hide resolved

openshift-ci bot assigned valaparthvi Mar 8, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 8, 2023

openshift-merge-robot merged commit 69a8383 into redhat-developer:main Mar 8, 2023

rm3l deleted the fix_issue_with_odo_describe_component_tests branch March 8, 2023 13:11

Conversation

rm3l commented Mar 8, 2023

Uh oh!

netlify bot commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for odo-docusaurus-preview canceled.

Uh oh!

sonarqubecloud bot commented Mar 8, 2023

Uh oh!

odo-robot bot commented Mar 8, 2023

Uh oh!

odo-robot bot commented Mar 8, 2023

Uh oh!

odo-robot bot commented Mar 8, 2023

Uh oh!

odo-robot bot commented Mar 8, 2023

Uh oh!

odo-robot bot commented Mar 8, 2023

Uh oh!

odo-robot bot commented Mar 8, 2023

Uh oh!

odo-robot bot commented Mar 8, 2023

Uh oh!

odo-robot bot commented Mar 8, 2023

Uh oh!

Uh oh!

rm3l commented Mar 8, 2023

Uh oh!

openshift-ci bot commented Mar 8, 2023

Uh oh!

rm3l commented Mar 8, 2023

Uh oh!

openshift-ci bot commented Mar 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Mar 8, 2023 •

edited

Loading