Skip to content

Update alizer dependency#6650

Merged
openshift-merge-robot merged 6 commits intoredhat-developer:mainfrom
kadel:update-alizer
Mar 25, 2023
Merged

Update alizer dependency#6650
openshift-merge-robot merged 6 commits intoredhat-developer:mainfrom
kadel:update-alizer

Conversation

@kadel
Copy link
Member

@kadel kadel commented Mar 9, 2023 •
edited
Loading

What type of PR is this:

What does this PR do / why we need it:

Update Alizer to the latest commit redhat-developer/alizer@ad2d305

Which issue(s) this PR fixes:

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@kadel kadel mentioned this pull request Mar 9, 2023
Closed
@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit c7eb6b9
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/641d6e10d09058000845acc9

@openshift-ci openshift-ci bot requested review from anandrkskd and feloy March 9, 2023 14:46
@odo-robot
Copy link

odo-robot bot commented Mar 9, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit a24c4e4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 9, 2023 •
edited
Loading

NoCluster Tests on commit a24c4e4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 9, 2023 •
edited
Loading

Unit Tests on commit a24c4e4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 9, 2023 •
edited
Loading

Validate Tests on commit a24c4e4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 9, 2023 •
edited
Loading

Windows Tests (OCP) on commit c247046 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 9, 2023 •
edited
Loading

Kubernetes Tests on commit a24c4e4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 9, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 52eb77a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 9, 2023 •
edited
Loading

OpenShift Tests on commit a24c4e4 finished successfully.
View logs: TXT HTML

rm3l
rm3l reviewed Mar 10, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment on the related issue: #6210 (comment)

@kadel
Copy link
Member Author

kadel commented Mar 15, 2023

Added a comment on the related issue: #6210 (comment)

oh, you are right.

I've removed "fix" from the issue description. This PR doesn't fix that issue, but I think that updating alizer still makes sense.

rm3l
rm3l requested changes Mar 15, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

go run -mod=vendor github.com/frapposelli/wwhrd check -q
ERRO[0008] Found Non-Approved license                    license=UNKNOWN package=github.com/pjbgf/sha1cd/ubc
ERRO[0008] Found Non-Approved license                    license=UNKNOWN package=github.com/pjbgf/sha1cd
ERRO[0008] Found Non-Approved license                    license=UNKNOWN package=github.com/pjbgf/sha1cd/cgo
FATA[0008] Exiting: Non-Approved license found          
exit status 1
make: *** [Makefile:109: validate-vendor-licenses] Error 1

License validation seems to fail. Not sure why wwhrd could not find the Apache 2.0 license for that indirect dependency..
Do we want to add an exception for this dependency?

@kadel
Copy link
Member Author

kadel commented Mar 15, 2023

License validation seems to fail. Not sure why wwhrd could not find the Apache 2.0 license for that indirect dependency..
Do we want to add an exception for this dependency?

I'll look into that

@rm3l
Copy link
Member

rm3l commented Mar 16, 2023 •
edited
Loading

I just noticed that the build of odo for this PR kept failing on the CI Windows machine because gcc is missing:

Create Binary
--------------------------------------------------------------------------------
go install -mod=vendor -ldflags="-X github.com/redhat-developer/odo/pkg/version.GITCOMMIT=c11916c" ./cmd/odo/
# github.com/pjbgf/sha1cd/cgo
cgo: C compiler "gcc" not found: exec: "gcc": executable file not found in %PATH%
make: *** [Makefile:90: install] Error 2

This seems to be caused by an upgrade of github.com/go-git/go-git to 5.5.1 (which introduced a cgo on github.com/pjbgf/sha1cd).
An issue was opened a while back: go-git/go-git#637; and it seems to be fixed in v5.6+.

Since go-git is also a direct dependency of odo, maybe we can update it to the latest version? And in this case, I guess we might not even need the license exceptions added in def2b1d (#6650)..

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Mar 18, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Mar 21, 2023
@rm3l rm3l mentioned this pull request Mar 24, 2023
Closed
@rm3l rm3l closed this Mar 24, 2023
@rm3l rm3l reopened this Mar 24, 2023
@rm3l rm3l closed this Mar 25, 2023
@rm3l rm3l reopened this Mar 25, 2023
@rm3l rm3l closed this Mar 25, 2023
@rm3l rm3l reopened this Mar 25, 2023
@rm3l rm3l added this to the v3.9.0 🚀 milestone Mar 25, 2023
@rm3l rm3l closed this Mar 25, 2023
@rm3l rm3l reopened this Mar 25, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l added the area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs label Mar 25, 2023
rm3l
rm3l approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  [FAILED] Expected
      <*url.Error | 0xc0005e33e0>: {
          Op: "Post",
          URL: "http://127.0.0.1:54632/api/newuser",
          Err: <*errors.errorString | 0xc000088130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3482/tests/e2escenarios/e2e_test.go:306 @ 03/25/23 10:37:27.085

  There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3482/tests/e2escenarios/e2e_test.go:306

Flaky E2E test (#6582)

/override windows-integration-test/Windows-test

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 25, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

Details

In response to this:

 [FAILED] Expected
     <*url.Error | 0xc0005e33e0>: {
         Op: "Post",
         URL: "http://127.0.0.1:54632/api/newuser",
         Err: <*errors.errorString | 0xc000088130>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3482/tests/e2escenarios/e2e_test.go:306 @ 03/25/23 10:37:27.085

 There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 C:/Users/Administrator.ANSIBLE-TEST-VS/3482/tests/e2escenarios/e2e_test.go:306

Flaky E2E test (#6582)

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6af2f9d into redhat-developer:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@feloy feloy Awaiting requested review from feloy

Assignees

@rm3l rm3l

Labels

area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

v3.9.0 🚀

Development

Successfully merging this pull request may close these issues.

3 participants

@kadel @rm3l @openshift-merge-robot