Add name detection to `odo analyze` by valaparthvi · Pull Request #6682 · redhat-developer/odo

valaparthvi · 2023-03-24T11:12:18Z

What type of PR is this:
/kind bug

What does this PR do / why we need it:
This PR adds missing name detection to odo analyze
Which issue(s) this PR fixes:

Fixes #6649

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:

mkdir /tmp/demo; cd /tmp/demo
odo init --devfile go --name my-go-app --starter go-starter --devfile-version latest
odo analyze -o json

netlify · 2023-03-24T11:12:24Z

✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	`8483355`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/642297c304fa56000707ea32
😎 Deploy Preview	https://deploy-preview-6682--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

odo-robot · 2023-03-24T11:17:20Z

Windows Tests (OCP) on commit 942a762 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-24T11:18:58Z

NoCluster Tests on commit 942a762 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-24T11:20:30Z

Unit Tests on commit 942a762 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-24T11:25:50Z

Validate Tests on commit 942a762 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-24T11:35:17Z

Kubernetes Tests on commit 942a762 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-24T11:53:00Z

OpenShift Tests on commit 942a762 finished with errors.
View logs: TXT HTML

Signed-off-by: Parthvi Vala <[email protected]>

odo-robot · 2023-03-26T09:14:17Z

OpenShift Unauthenticated Tests on commit 942a762 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-26T09:42:44Z

Kubernetes Docs Tests on commit d0edfb6 finished successfully.
View logs: TXT HTML

valaparthvi · 2023-03-27T06:09:11Z

/override OpenShift-Integration-tests/OpenShift-Integration-tests

 [FAILED] Timed out after 180.001s.
  Expected
      <string>:  âš   Pod is Terminating
       âœ—  Finished executing the application (command: devrun) [42s]
       âš   No pod exists
       âš   Pod is Pending
       âœ“  Pod is Running
       â€¢  Syncing files into the container  ...
      
 âœ“  Syncing files into the container [729ms]
       â€¢  Building your application in container (command: devbuild)  ...
      
 âœ“  Building your application in container (command: devbuild) [4s]
       â€¢  Executing the application (command: devrun)  ...
       -  Forwarding from 127.0.0.1:46755 -> 3000
      
      
      â†ª Dev mode
       Keyboard Commands:
      [Ctrl+c] - Exit and delete resources from the cluster
           [p] - Manually apply local changes to the application on the cluster
      
  To satisfy at least one of these matchers: [%!s(*matchers.ContainSubstringMatcher=&{Pushing files... []}) %!s(*matchers.ContainSubstringMatcher=&{Updating Component... []})]
  In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:64 @ 03/26/23 09:31:00.809
  [FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [BeforeEach] should react on the Devfile modification

openshift-ci · 2023-03-27T06:09:15Z

@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] Timed out after 180.001s.
 Expected
     <string>:  âš   Pod is Terminating
      âœ—  Finished executing the application (command: devrun) [42s]
      âš   No pod exists
      âš   Pod is Pending
      âœ“  Pod is Running
      â€¢  Syncing files into the container  ...
     
âœ“  Syncing files into the container [729ms]
      â€¢  Building your application in container (command: devbuild)  ...
     
âœ“  Building your application in container (command: devbuild) [4s]
      â€¢  Executing the application (command: devrun)  ...
      -  Forwarding from 127.0.0.1:46755 -> 3000
     
     
     â†ª Dev mode
      Keyboard Commands:
     [Ctrl+c] - Exit and delete resources from the cluster
          [p] - Manually apply local changes to the application on the cluster
     
 To satisfy at least one of these matchers: [%!s(*matchers.ContainSubstringMatcher=&{Pushing files... []}) %!s(*matchers.ContainSubstringMatcher=&{Updating Component... []})]
 In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:64 @ 03/26/23 09:31:00.809
 [FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [BeforeEach] should react on the Devfile modification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

valaparthvi · 2023-03-27T07:15:21Z

/override windows-integration-test/Windows-test

  Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375
  Unable to delete C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375 on attempt #10, trying again...
  [odo] I0326 04:35:14.791379    9708 watch.go:449] Copying files [] to pod
  [odo] I0326 04:35:14.791570    9708 util.go:198] path devfile.yaml doesn't exist, skipping it
  [odo] I0326 04:35:14.791570    9708 util.go:198] path .devfile.yaml doesn't exist, skipping it
  [odo] I0326 04:35:14.791570    9708 context.go:159] absolute devfile path: 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml'
  [odo] I0326 04:35:14.791570    9708 context.go:110] absolute devfile path: 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml'
  [odo] I0326 04:35:14.791570    9708 watch.go:470] Error from Push: unable to generate component from watch parameters: failed to populateAndParseDevfile: failed to read devfile from path 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml': open C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml: The system cannot find the file specified.
  [odo] I0326 04:35:14.791570    9708 backo.go:23] wait for 10s
  [odo] Error occurred on Push - unable to generate component from watch parameters: failed to populateAndParseDevfile: failed to read devfile from path 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml': open C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml: The system cannot find the file specified.
  [odo] 
  Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375
  Unable to delete C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375 on attempt #11, trying again...
  [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3483/tests/helper/helper_filesystem.go:48 @ 03/26/23 04:35:23.957
  << Timeline

  [FAILED] Expected
      <*url.Error | 0xc0000b9020>: {
          Op: "Post",
          URL: "http://127.0.0.1:61069/api/newuser",
          Err: <*errors.errorString | 0xc000088130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3483/tests/e2escenarios/e2e_test.go:306 @ 03/26/23 04:33:17.6

  There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop

openshift-ci · 2023-03-27T07:15:26Z

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test

 Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375
 Unable to delete C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375 on attempt #10, trying again...
 [odo] I0326 04:35:14.791379    9708 watch.go:449] Copying files [] to pod
 [odo] I0326 04:35:14.791570    9708 util.go:198] path devfile.yaml doesn't exist, skipping it
 [odo] I0326 04:35:14.791570    9708 util.go:198] path .devfile.yaml doesn't exist, skipping it
 [odo] I0326 04:35:14.791570    9708 context.go:159] absolute devfile path: 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml'
 [odo] I0326 04:35:14.791570    9708 context.go:110] absolute devfile path: 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml'
 [odo] I0326 04:35:14.791570    9708 watch.go:470] Error from Push: unable to generate component from watch parameters: failed to populateAndParseDevfile: failed to read devfile from path 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml': open C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml: The system cannot find the file specified.
 [odo] I0326 04:35:14.791570    9708 backo.go:23] wait for 10s
 [odo] Error occurred on Push - unable to generate component from watch parameters: failed to populateAndParseDevfile: failed to read devfile from path 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml': open C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml: The system cannot find the file specified.
 [odo] 
 Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375
 Unable to delete C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375 on attempt #11, trying again...
 [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3483/tests/helper/helper_filesystem.go:48 @ 03/26/23 04:35:23.957
 << Timeline

 [FAILED] Expected
     <*url.Error | 0xc0000b9020>: {
         Op: "Post",
         URL: "http://127.0.0.1:61069/api/newuser",
         Err: <*errors.errorString | 0xc000088130>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3483/tests/e2escenarios/e2e_test.go:306 @ 03/26/23 04:33:17.6

 There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rm3l

Can you also update the odo analyze documentation and sample output?
https://odo.dev/docs/command-reference/json-output#odo-analyze--o-json

tests/helper/helper_generic.go

tests/integration/cmd_analyze_test.go

rm3l · 2023-03-27T13:51:53Z

What type of PR is this: /kind bug

What does this PR do / why we need it: This PR adds missing name detection to odo analyze Which issue(s) this PR fixes:

Fixes #

This PR should fix #6649, no?

Co-authored-by: Armel Soro <[email protected]>

Signed-off-by: Parthvi Vala <[email protected]>

sonarqubecloud · 2023-03-28T07:32:05Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.3% Duplication

rm3l

Thanks for the changes! Tested and approved! ;-)

feloy · 2023-03-28T14:25:21Z

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Flaky test

[FAILED] [72.627 seconds]
odo logs command tests when component is created and odo logs is executed when running in both Dev and Deploy mode [It] should successfully show logs of the running component
/go/odo_1/tests/integration/cmd_logs_test.go:247

feloy · 2023-03-28T14:34:28Z

/override OpenShift-Integration-tests/OpenShift-Integration-tests

openshift-ci · 2023-03-28T14:34:33Z

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

valaparthvi · 2023-03-28T14:45:40Z

/test ci/prow/v4.12-images

openshift-ci · 2023-03-28T14:45:44Z

@valaparthvi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test v4.10-images
/test v4.11-images
/test v4.12-images
/test v4.13-images

Use /test all to run all jobs.

Details

In response to this:

/test ci/prow/v4.12-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

valaparthvi · 2023-03-28T14:46:00Z

/test v4.12-images

openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 24, 2023

openshift-ci bot requested review from anandrkskd and rnapoles-rh March 24, 2023 11:12

valaparthvi changed the title ~~Add name detection to odo analyze~~ WIP: Add name detection to odo analyze Mar 24, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 24, 2023

valaparthvi requested review from feloy and rm3l and removed request for anandrkskd and rnapoles-rh March 24, 2023 11:12

valaparthvi force-pushed the alizer branch from 1b50588 to 7531cc1 Compare March 24, 2023 13:30

valaparthvi changed the title ~~WIP: Add name detection to odo analyze~~ Add name detection to odo analyze Mar 24, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 24, 2023

Add name detection to odo analyze

113e093

Signed-off-by: Parthvi Vala <[email protected]>

valaparthvi force-pushed the alizer branch from 7531cc1 to 113e093 Compare March 24, 2023 20:42

valaparthvi closed this Mar 26, 2023

valaparthvi reopened this Mar 26, 2023

rm3l requested changes Mar 27, 2023

View reviewed changes

tests/helper/helper_generic.go Outdated Show resolved Hide resolved

tests/integration/cmd_analyze_test.go Outdated Show resolved Hide resolved

openshift-ci bot assigned rm3l Mar 27, 2023

valaparthvi and others added 3 commits March 28, 2023 12:56

Update tests/helper/helper_generic.go

7899d52

Co-authored-by: Armel Soro <[email protected]>

Update tests/integration/cmd_analyze_test.go

87a0187

Co-authored-by: Armel Soro <[email protected]>

Update odo analyze documentation

8483355

Signed-off-by: Parthvi Vala <[email protected]>

rm3l approved these changes Mar 28, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 28, 2023

openshift-merge-robot merged commit 61d53dc into redhat-developer:main Mar 28, 2023

Conversation

valaparthvi commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for odo-docusaurus-preview ready!

Uh oh!

odo-robot bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Mar 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Mar 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

valaparthvi commented Mar 27, 2023

Uh oh!

openshift-ci bot commented Mar 27, 2023

Uh oh!

valaparthvi commented Mar 27, 2023

Uh oh!

openshift-ci bot commented Mar 27, 2023

Uh oh!

rm3l left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rm3l commented Mar 27, 2023

Uh oh!

sonarqubecloud bot commented Mar 28, 2023

Uh oh!

rm3l left a comment

Choose a reason for hiding this comment

Uh oh!

feloy commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feloy commented Mar 28, 2023

Uh oh!

openshift-ci bot commented Mar 28, 2023

Uh oh!

valaparthvi commented Mar 28, 2023

Uh oh!

openshift-ci bot commented Mar 28, 2023

Uh oh!

valaparthvi commented Mar 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

valaparthvi commented Mar 24, 2023 •

edited

Loading

netlify bot commented Mar 24, 2023 •

edited

Loading

odo-robot bot commented Mar 24, 2023 •

edited

Loading

odo-robot bot commented Mar 24, 2023 •

edited

Loading

odo-robot bot commented Mar 24, 2023 •

edited

Loading

odo-robot bot commented Mar 24, 2023 •

edited

Loading

odo-robot bot commented Mar 24, 2023 •

edited

Loading

odo-robot bot commented Mar 24, 2023 •

edited

Loading

odo-robot bot commented Mar 26, 2023 •

edited

Loading

odo-robot bot commented Mar 26, 2023 •

edited

Loading

rm3l left a comment •

edited

Loading

feloy commented Mar 28, 2023 •

edited

Loading