Fix issue preventing app from being restarted if /proc/[pid]/task/[tid]/children is missing in container (case of Minikube with VirtualBox or KVM drivers)#6690
Conversation
|
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
/proc/*/stat files instead of /proc/*/task/*/children
/proc/*/stat files instead of /proc/*/task/*/children/proc/*/stat instead of /proc/*/task/*/children
/proc/*/stat instead of /proc/*/task/*/children/proc/[pid]/stat instead of /proc/[pid]/task/[tid]/children
/proc/[pid]/stat instead of /proc/[pid]/task/[tid]/children/proc/[pid]/task/[tid]/children is missing
/proc/[pid]/task/[tid]/children is missing/proc/[pid]/task/[tid]/children is missing
…of relying on "/proc/*/task/*/children" Co-authored-by: Parthvi Vala <[email protected]> Co-authored-by: Philippe Martin <[email protected]>
…tion on test files
Co-authored-by: Parthvi Vala <[email protected]>
The implementation no longer relies on the presence of this file.
This makes the intent of this method clearer, so we don't try to kill the root ppid twice.
549905b to
4e133b1
Compare
|
/lgtm |
Flaky E2E test (#6582) /override windows-integration-test/Windows-test |
|
@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/proc/[pid]/task/[tid]/children is missing/proc/[pid]/task/[tid]/children is missing in container (case of Minikube with VirtualBox or KVM drivers)
|
Kudos, SonarCloud Quality Gate passed!
|
Previous run passed - flaky test (to be addressed by #6545) /override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests |
|
@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Previous run of the same test passed. /override OpenShift-Integration-tests/OpenShift-Integration-tests |
|
@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Flaky test - previous run of the same test passed. /override windows-integration-test/Windows-test |
|
@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |








What type of PR is this:
/kind bug
/area dev
What does this PR do / why we need it:
Which issue(s) this PR fixes:
As depicted in #6263, this issue might happen if the host kernel is not configured with the
CONFIG_PROC_CHILDRENconfig, which is currently the case with some platforms (like Minikube and its VirtualBox or KVM2 drivers).So this PR changes the way we determine a process children, by reading all
/proc/*/statfiles instead, so we can reliably stop them.Fixes #6263
Co-authored-by: @valaparthvi
Co-authored-by: @feloy
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: