Skip to content

Get DEVFILE_REGISTRY value for tests, to use local Registry#6705

Merged
openshift-merge-robot merged 3 commits intoredhat-developer:mainfrom
feloy:dev/local-devfile-registry
Mar 31, 2023
Merged

Get DEVFILE_REGISTRY value for tests, to use local Registry#6705
openshift-merge-robot merged 3 commits intoredhat-developer:mainfrom
feloy:dev/local-devfile-registry

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Mar 31, 2023

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes partially #6702

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Mar 31, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 049e6fd
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6426e6b7ea129f0008e2f95b
😎 Deploy Preview https://deploy-preview-6705--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@feloy feloy closed this Mar 31, 2023
@feloy feloy reopened this Mar 31, 2023
@odo-robot
Copy link

odo-robot bot commented Mar 31, 2023 •
edited
Loading

Windows Tests (OCP) on commit 6428db8 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 31, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 6428db8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 31, 2023 •
edited
Loading

Unit Tests on commit 6428db8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 31, 2023 •
edited
Loading

NoCluster Tests on commit 6428db8 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the dev/local-devfile-registry branch from 944b4ad to c457b70 Compare March 31, 2023 12:36
@feloy feloy mentioned this pull request Mar 31, 2023
Closed
5 tasks
@odo-robot
Copy link

odo-robot bot commented Mar 31, 2023 •
edited
Loading

OpenShift Tests on commit 6428db8 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 31, 2023 •
edited
Loading

Validate Tests on commit 6428db8 finished successfully.
View logs: TXT HTML

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Mar 31, 2023 •
edited
Loading

Kubernetes Tests on commit 6428db8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 31, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 08c3904 finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor Author

feloy commented Mar 31, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Previous job passed

[FAILED] [130.650 seconds]
odo add binding interactive command tests when running a deployment [It] should successfully add binding without devfile (default naming strategy)
/go/odo_1/tests/integration/interactive_add_binding_test.go:311

✗  Internal error occurred: failed calling webhook "vservicebinding.kb.io": Post "[https://service-binding-operator-service.openshift-operators.svc:443/validate-binding-operators-coreos-com-v1alpha1-servicebinding?timeout=10s":](https://service-binding-operator-service.openshift-operators.svc/validate-binding-operators-coreos-com-v1alpha1-servicebinding?timeout=10s%22:) EOF

@openshift-ci
Copy link

openshift-ci bot commented Mar 31, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Previous job passed

[FAILED] [130.650 seconds]
odo add binding interactive command tests when running a deployment [It] should successfully add binding without devfile (default naming strategy)
/go/odo_1/tests/integration/interactive_add_binding_test.go:311

✗  Internal error occurred: failed calling webhook "vservicebinding.kb.io": Post "[https://service-binding-operator-service.openshift-operators.svc:443/validate-binding-operators-coreos-com-v1alpha1-servicebinding?timeout=10s":](https://service-binding-operator-service.openshift-operators.svc/validate-binding-operators-coreos-com-v1alpha1-servicebinding?timeout=10s%22:) EOF

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Mar 31, 2023

/override windows-integration-test/Windows-test

Flaky e2e test

[FAILED] [207.576 seconds]
E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
C:/Users/Administrator.ANSIBLE-TEST-VS/3568/tests/e2escenarios/e2e_test.go:337

@openshift-ci
Copy link

openshift-ci bot commented Mar 31, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test

Flaky e2e test

[FAILED] [207.576 seconds]
E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
C:/Users/Administrator.ANSIBLE-TEST-VS/3568/tests/e2escenarios/e2e_test.go:337

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy feloy requested a review from rm3l March 31, 2023 15:55
rm3l
rm3l approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 31, 2023
@rm3l rm3l added this to the v3.9.0 🚀 milestone Mar 31, 2023
@rm3l rm3l added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Mar 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit 235539d into redhat-developer:main Mar 31, 2023
@valaparthvi valaparthvi mentioned this pull request Apr 6, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels

area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

v3.9.0 🚀

Development

Successfully merging this pull request may close these issues.

3 participants

@feloy @rm3l @openshift-merge-robot