Skip to content

Revert "Add DEVFILE_REGISTRY env var for periodic tests (#6709)"#6725

Merged
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
valaparthvi:revert-periodic-tests-registry
Apr 12, 2023
Merged

Revert "Add DEVFILE_REGISTRY env var for periodic tests (#6709)"#6725
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
valaparthvi:revert-periodic-tests-registry

Conversation

@valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Apr 6, 2023

This reverts commit f0bf9ee.

What type of PR is this:
/area testing

What does this PR do / why we need it:
PR #6709 modified the periodic tests to use the Devfile registry setup on IBM cloud because of the broken Staging Registry. But it would be helpful to have our tests use the Staging Registry in order to catch any problem with it early on before it propagates to the Production Registry.

This PR reverts back to using the Staging Registry.

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Apr 6, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit a4527aa
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/643671206f34f10008eb9480
😎 Deploy Preview https://deploy-preview-6725--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Apr 6, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and rnapoles-rh April 6, 2023 13:33
@valaparthvi valaparthvi mentioned this pull request Apr 6, 2023
Closed
4 tasks
@valaparthvi valaparthvi requested review from feloy and rm3l April 6, 2023 13:52
@feloy
Copy link
Contributor

feloy commented Apr 6, 2023

Thanks @valaparthvi for taking this over
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 6, 2023
@odo-robot
Copy link

odo-robot bot commented Apr 6, 2023 •
edited
Loading

NoCluster Tests on commit 30d6cbe finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 6, 2023 •
edited
Loading

Unit Tests on commit 30d6cbe finished successfully.
View logs: TXT HTML

rm3l
rm3l reviewed Apr 6, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 6, 2023
@rm3l rm3l added this to the v3.10.0 🚀 milestone Apr 6, 2023
@odo-robot
Copy link

odo-robot bot commented Apr 6, 2023 •
edited
Loading

Validate Tests on commit 30d6cbe finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 6, 2023 •
edited
Loading

Kubernetes Tests on commit 30d6cbe finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 6, 2023 •
edited
Loading

Kubernetes Docs Tests on commit e6a7f02 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 6, 2023 •
edited
Loading

Windows Tests (OCP) on commit 30d6cbe finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 6, 2023 •
edited
Loading

OpenShift Tests on commit 30d6cbe finished successfully.
View logs: TXT HTML

rm3l
rm3l requested changes Apr 11, 2023
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 11, 2023
@rm3l rm3l removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 11, 2023
@valaparthvi valaparthvi force-pushed the revert-periodic-tests-registry branch from 66012f3 to a4527aa Compare April 12, 2023 08:51
@odo-robot
Copy link

odo-robot bot commented Apr 12, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 30d6cbe finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi requested a review from rm3l April 12, 2023 09:43
@valaparthvi valaparthvi reopened this Apr 12, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.3% 0.3% Duplication

rm3l
rm3l approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 12, 2023
@rm3l
Copy link
Member

rm3l commented Apr 12, 2023 

 V  Creating resource Service/my-cs 
  [odo] 
  [odo] Your Devfile has been successfully deployed
  Running oc.exe with args [oc get deployment -n cmd-delete-test434enl] and odo env: []
  [oc] Unable to connect to the server: dial tcp 161.156.12.82:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3673/tests/helper/helper_oc.go:34 @ 04/12/23 05:23:51.321
  Deleting project: cmd-delete-test434enl
  Running oc.exe with args [oc delete project cmd-delete-test434enl --wait=false] and odo env: []
...
Summarizing 1 Failure:
  [FAIL] odo delete command tests when a component is bootstrapped using a devfile.yaml with URI-referenced Kubernetes components when the component is deployed in DEPLOY mode [BeforeEach] when the component is deleted using its name and namespace from another directory should output that there are no resources to be deleted
  C:/Users/Administrator.ANSIBLE-TEST-VS/3673/tests/helper/helper_oc.go:34

Ran 432 of 800 Specs in 1098.125 seconds
FAIL! -- 431 Passed | 1 Failed | 0 Pending | 368 Skipped

Not related.

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

Details

In response to this:

V  Creating resource Service/my-cs 
 [odo] 
 [odo] Your Devfile has been successfully deployed
 Running oc.exe with args [oc get deployment -n cmd-delete-test434enl] and odo env: []
 [oc] Unable to connect to the server: dial tcp 161.156.12.82:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
 [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3673/tests/helper/helper_oc.go:34 @ 04/12/23 05:23:51.321
 Deleting project: cmd-delete-test434enl
 Running oc.exe with args [oc delete project cmd-delete-test434enl --wait=false] and odo env: []
...
Summarizing 1 Failure:
 [FAIL] odo delete command tests when a component is bootstrapped using a devfile.yaml with URI-referenced Kubernetes components when the component is deployed in DEPLOY mode [BeforeEach] when the component is deleted using its name and namespace from another directory should output that there are no resources to be deleted
 C:/Users/Administrator.ANSIBLE-TEST-VS/3673/tests/helper/helper_oc.go:34

Ran 432 of 800 Specs in 1098.125 seconds
FAIL! -- 431 Passed | 1 Failed | 0 Pending | 368 Skipped

Not related.

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 4317255 into redhat-developer:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

@feloy feloy Awaiting requested review from feloy

Assignees

@rm3l rm3l

@feloy feloy

Labels

area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

v3.10.0 🚀

Development

Successfully merging this pull request may close these issues.

5 participants

@valaparthvi @feloy @rm3l @anandrkskd @openshift-merge-robot