Skip to content

For custom port mapping, handle case where ranged random port matches a custom local port#6727

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
valaparthvi:followup-custom-port-mapping
Apr 12, 2023
Merged

For custom port mapping, handle case where ranged random port matches a custom local port#6727
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
valaparthvi:followup-custom-port-mapping

Conversation

@valaparthvi
Copy link
Contributor

What type of PR is this:
/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes part of #6479

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

  1. odo init --devfile nodejs --starter nodejs-starter
  2. odo dev --port-forward 20001:5858 --debug
    Resulting port mapping: 3000 -> 20002, 5858 -> 20001

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 10, 2023
@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 126d81a
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6433f69c8f7c3b0008dfa63d

@openshift-ci openshift-ci bot requested review from feloy and kadel April 10, 2023 07:05
@odo-robot
Copy link

odo-robot bot commented Apr 10, 2023

NoCluster Tests on commit f16aa98 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 10, 2023

Unit Tests on commit f16aa98 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 10, 2023

Validate Tests on commit f16aa98 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 10, 2023

Kubernetes Tests on commit f16aa98 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 10, 2023

Windows Tests (OCP) on commit f16aa98 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 10, 2023

OpenShift Tests on commit f16aa98 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 10, 2023

Kubernetes Docs Tests on commit fa9524e finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi force-pushed the followup-custom-port-mapping branch from 29f464d to 126d81a Compare April 10, 2023 11:44
@odo-robot
Copy link

odo-robot bot commented Apr 11, 2023

OpenShift Unauthenticated Tests on commit f16aa98 finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor Author

  [FAILED] user-guides/quickstart/docs-mdx/go/go_odo_dev_output.mdx
  Expected
      <string>:   (
        	"""
        	... // 9 identical lines
        	•  Waiting for Kubernetes resources  ...
        	âš   Pod is Pending
      - 	✓  Pod is Running
        	✓  Syncing files into the container [1s]
        	✓  Building your application in container (command: build) [1s]
        	... // 9 identical lines
        	[Ctrl+c] - Exit and delete resources from the cluster
        	[p] - Manually apply local changes to the application on the cluster
      + 	✓  Pod is Running
        	```
        	"""
        )
      

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

Details

In response to this:

 [FAILED] user-guides/quickstart/docs-mdx/go/go_odo_dev_output.mdx
 Expected
     <string>:   (
       	"""
       	... // 9 identical lines
       	•  Waiting for Kubernetes resources  ...
       	âš   Pod is Pending
     - 	✓  Pod is Running
       	✓  Syncing files into the container [1s]
       	✓  Building your application in container (command: build) [1s]
       	... // 9 identical lines
       	[Ctrl+c] - Exit and delete resources from the cluster
       	[p] - Manually apply local changes to the application on the cluster
     + 	✓  Pod is Running
       	```
       	"""
       )
     

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 11, 2023
@rm3l rm3l added this to the v3.10.0 🚀 milestone Apr 11, 2023
@rm3l rm3l closed this Apr 11, 2023
@rm3l rm3l reopened this Apr 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@valaparthvi
Copy link
Contributor Author

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  /go/odo_1/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 170.404 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 /go/odo_1/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 170.404 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor Author

+++++++++++

Summarizing 1 Failure:
  [FAIL] odo describe/list binding command tests [BeforeEach] when creating a component with a binding as environment variables (service in namespace "") when Starting a Pg service when running dev session when changing the current namespace should list the binding with --namespace flag
  C:/Users/Administrator.ANSIBLE-TEST-VS/3668/tests/helper/helper_cmd_wrapper.go:101

Ran 437 of 805 Specs in 1160.226 seconds
FAIL! -- 436 Passed | 1 Failed | 0 Pending | 368 Skipped

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

Details

In response to this:

+++++++++++

Summarizing 1 Failure:
 [FAIL] odo describe/list binding command tests [BeforeEach] when creating a component with a binding as environment variables (service in namespace "") when Starting a Pg service when running dev session when changing the current namespace should list the binding with --namespace flag
 C:/Users/Administrator.ANSIBLE-TEST-VS/3668/tests/helper/helper_cmd_wrapper.go:101

Ran 437 of 805 Specs in 1160.226 seconds
FAIL! -- 436 Passed | 1 Failed | 0 Pending | 368 Skipped

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e6a7f02 into redhat-developer:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants