Skip to content

Allow using imageName as a selector#6768

Merged
openshift-merge-robot merged 11 commits intoredhat-developer:mainfrom
rm3l:6677-image-name-as-selector-implementation-in-odo
May 22, 2023
Merged

Allow using imageName as a selector#6768
openshift-merge-robot merged 11 commits intoredhat-developer:mainfrom
rm3l:6677-image-name-as-selector-implementation-in-odo

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Apr 24, 2023 •
edited
Loading

What type of PR is this:
/kind feature
/area devfile-spec

What does this PR do / why we need it:
This PR allows handling imageName field on Image components as a selector. This means that, for each Image component with a relative image name, odo will automatically build and push a fully qualified image (using a user-defined registry and a generated image tag), and will replace any matching image names found in any Container or Kubernetes/OpenShift components.
See devfile/api#985 (comment) for more context and details.

For this to work however, this PR exposes a new ImageRegistry preference, which users need to set first. And, for Kubernetes/OpenShift components, replacement is done for matching image names found in core Kubernetes resources (like Pods, Deployments, DaemonSets, ...).

Which issue(s) this PR fixes:
Fixes #6677

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

  1. Set a global image registry in the preferences, e.g.: odo preference set ImageRegistry "quay.io/$USER"
  2. At this point, odo will treat all relative image names in Devfile Image components as selectors, i.e.:
  • it will replace the value in all matching Container and resources in Kubernetes/OpenShift Components (for Kubernetes/OpenShift components, for now, this handles only images referenced in core Kubernetes resources: CronJob, Job, Pod, DaemonSet, Deployment, ReplicaSet, ReplicationController, StatefulSet)
  • Non-matching image names will not be updated.

See devfile/api#985 (comment) for examples of how image names are matched against selectors.

Note that this behavior applies to both odo dev and odo deploy, and should work the same way on both Podman and cluster.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Apr 24, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit eb575c8
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64676ca14a3b310008a88a8a
😎 Deploy Preview https://deploy-preview-6768--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Apr 24, 2023 •
edited
Loading

NoCluster Tests on commit 31afd34 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 24, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 31afd34 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 24, 2023 •
edited
Loading

Unit Tests on commit 31afd34 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 24, 2023 •
edited
Loading

Validate Tests on commit 31afd34 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 24, 2023 •
edited
Loading

Windows Tests (OCP) on commit 31afd34 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 24, 2023 •
edited
Loading

Kubernetes Tests on commit 31afd34 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 24, 2023 •
edited
Loading

OpenShift Tests on commit 31afd34 finished with errors.
View logs: TXT HTML

@rm3l rm3l force-pushed the 6677-image-name-as-selector-implementation-in-odo branch from 3728d7d to 087f3c3 Compare April 25, 2023 14:07
@rm3l rm3l added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels Apr 25, 2023
@odo-robot
Copy link

odo-robot bot commented Apr 25, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 59e7905 finished successfully.
View logs: TXT HTML

@rm3l rm3l force-pushed the 6677-image-name-as-selector-implementation-in-odo branch 2 times, most recently from 0b63226 to aebee2d Compare April 26, 2023 11:03
@rm3l rm3l mentioned this pull request Apr 26, 2023
Closed
@rm3l rm3l force-pushed the 6677-image-name-as-selector-implementation-in-odo branch 2 times, most recently from b0f98a9 to 928dc86 Compare April 26, 2023 15:59
@rm3l rm3l closed this Apr 27, 2023
@rm3l rm3l reopened this Apr 27, 2023
@rm3l rm3l mentioned this pull request Apr 28, 2023
Closed
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 2, 2023
@rm3l rm3l force-pushed the 6677-image-name-as-selector-implementation-in-odo branch from 928dc86 to ef35008 Compare May 4, 2023 15:17
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 4, 2023
@rm3l rm3l force-pushed the 6677-image-name-as-selector-implementation-in-odo branch from ef35008 to b88c24d Compare May 5, 2023 10:26
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 10, 2023
@rm3l rm3l marked this pull request as ready for review May 16, 2023 14:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 16, 2023
@openshift-ci openshift-ci bot requested review from kadel and ritudes May 16, 2023 14:02
@rm3l rm3l requested review from feloy and valaparthvi and removed request for ritudes May 16, 2023 14:03
feloy
feloy reviewed May 17, 2023
View reviewed changes
feloy
feloy reviewed May 17, 2023
View reviewed changes
tests/integration/cmd_devfile_init_test.go Outdated
Comment on lines +428 to +433
By("creating a different Devfile", func() {
b, err := os.ReadFile(filepath.Join(commonVar.Context, "devfile.yaml"))
Expect(err).To(BeNil())
devfileContent := string(b)
Expect(devfileContent).ShouldNot(BeEquivalentTo(originalDevfileContent))
})
Copy link
Contributor

@feloy feloy May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it what we want? We are changing the behaviour, as odo init was copying the child devfile as is before

Copy link
Member Author

@rm3l rm3l May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops - I missed your comments..
Indeed, previously, the child Devfile was copied as is. Then it was parsed by odo init to set user-defined fields like the component name. The test here was previously asserting that the resulting Devfile had the same fields as the original one.
But now, with the new changes in the Devfile library, this Devfile can no longer be parsed. My initial goal was to make odo init always return an effective Devfile as a result. But with your comments, I agree this is a change in behavior and can be discussed and considered separately.
I'll revert the changes done here and report the parsing issue to the Devfile library.

Copy link
Member Author

@rm3l rm3l May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue reported in devfile/api#1119, and changes done in 3603642 (#6768)

@rm3l rm3l mentioned this pull request May 19, 2023
Closed
rm3l and others added 3 commits May 19, 2023 14:28
@rm3l @feloy
Revert "Fix 'odo init' integration tests"
c072709 
This reverts commit 78868b0.

Co-authored-by: Philippe Martin <[email protected]>
@rm3l @feloy
Do not make odo init return an effective Devfile as a result
3603642 
This would change the behavior of `odo init`.

Furthermore, due to an issue [1] in the Devfile library,
it is not possible to parse some Devfiles with parents linked as GitHub URLs (like GitHub release artifacts).

[1] devfile/api#1119

Co-authored-by: Philippe Martin <[email protected]>
@rm3l
fixup! Document how odo now handles relative image names as selectors
eb575c8
@rm3l rm3l requested a review from feloy May 19, 2023 12:45
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 22, 2023
@rm3l rm3l closed this May 22, 2023
@rm3l rm3l reopened this May 22, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l
Copy link
Member Author

rm3l commented May 22, 2023 


  [FAILED] Expected
      <*url.Error | 0xc00034cfc0>: {
          Op: "Post",
          URL: "http://127.0.0.1:40113/api/newuser",
          Err: <*errors.errorString | 0xc000072130>{s: "EOF"},
      }
  to be nil
  In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 05/22/23 11:37:22.865
...

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  /go/odo_1/tests/e2escenarios/e2e_test.go:431

Ran 4 of 4 Specs in 238.104 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 0 Skipped


Ginkgo ran 1 suite in 4m22.014363676s

Flaky E2E test (#6582)

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:


 [FAILED] Expected
     <*url.Error | 0xc00034cfc0>: {
         Op: "Post",
         URL: "http://127.0.0.1:40113/api/newuser",
         Err: <*errors.errorString | 0xc000072130>{s: "EOF"},
     }
 to be nil
 In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 05/22/23 11:37:22.865
...

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 /go/odo_1/tests/e2escenarios/e2e_test.go:431

Ran 4 of 4 Specs in 238.104 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 0 Skipped


Ginkgo ran 1 suite in 4m22.014363676s

Flaky E2E test (#6582)

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented May 22, 2023 

  ? What configuration do you want change? Add new environment variable  [Use arrows to move, type to filter]
  > Add new environment variable
  ? What configuration do you want change? Add new environment variable
  ? Enter new environment variable name: 
  ======================
  Unexpected error:
      <*xpty.errPassthroughTimeout | 0xc00185ce30>: {
          error: <*errors.errorString | 0xc00185ce20>{
              s: "passthrough i/o timeout",
          },
      }
      passthrough i/o timeout
  occurred
  In [It] at: /go/odo_1/tests/helper/helper_interactive.go:111 @ 05/22/23 11:08:22.749
------------------------------

Summarizing 1 Failure:
  [FAIL] odo init interactive command tests label unauth personalizing Devfile configuration [It] should allow for personalizing configurations [unauth]
  /go/odo_1/tests/helper/helper_interactive.go:111

Ran 111 of 890 Specs in 135.020 seconds
FAIL! -- 110 Passed | 1 Failed | 0 Pending | 779 Skipped

Same issue with interactive tests, as reported in #6812.

Overriding because the previous run passed, and there is an ongoing PR (#6830) for this specific issue.

/override OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests

Details

In response to this:

 ? What configuration do you want change? Add new environment variable  [Use arrows to move, type to filter]
 > Add new environment variable
 ? What configuration do you want change? Add new environment variable
 ? Enter new environment variable name: 
 ======================
 Unexpected error:
     <*xpty.errPassthroughTimeout | 0xc00185ce30>: {
         error: <*errors.errorString | 0xc00185ce20>{
             s: "passthrough i/o timeout",
         },
     }
     passthrough i/o timeout
 occurred
 In [It] at: /go/odo_1/tests/helper/helper_interactive.go:111 @ 05/22/23 11:08:22.749
------------------------------

Summarizing 1 Failure:
 [FAIL] odo init interactive command tests label unauth personalizing Devfile configuration [It] should allow for personalizing configurations [unauth]
 /go/odo_1/tests/helper/helper_interactive.go:111

Ran 111 of 890 Specs in 135.020 seconds
FAIL! -- 110 Passed | 1 Failed | 0 Pending | 779 Skipped

Same issue with interactive tests, as reported in #6812.

Overriding because the previous run passed, and there is an ongoing PR (#6830) for this specific issue.

/override OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented May 22, 2023 

+ [FAILED] [21.463 seconds]
odo delete command tests [BeforeEach] when a component is bootstrapped using a devfile.yaml with URI-referenced Kubernetes components when the component is running in both DEV and DEPLOY mode and dev mode is killed when the component is deleted while having access to the devfile.yaml should delete the appropriate resources
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_delete_test.go:25
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_delete_test.go:625

  Timeline >>
  Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\1356430847
  Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\4066833606
  Setting KUBECONFIG=C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\4066833606\config
  Creating a new project: cmd-delete-test625txw
  Running oc.exe with args [oc new-project cmd-delete-test625txw] and odo env: []
  [oc] Unable to connect to the server: dial tcp 149.81.180.114:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/helper/helper_cmd_wrapper.go:101 @ 05/22/23 06:06:25.182
  Setting current dir to: 
  [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/helper/helper_filesystem.go:90 @ 05/22/23 06:06:25.184
  << Timeline

...
  Running oc.exe with args [oc get pods --namespace cmd-dev-test2781rgp --selector=component=javaspringboot-vnnlcc -o jsonpath={.items[*].metadata.name}] and odo env: []
  [oc] javaspringboot-vnnlcc-app-6f985c85fb-rh4bfRunning oc.exe with args [oc exec javaspringboot-vnnlcc-app-6f985c85fb-rh4bf --namespace cmd-dev-test2781rgp -c runtime -- bash -c grep [s]pring-boot:run /proc/*/cmdline] and odo env: []
  [oc] Unable to connect to the server: dial tcp 161.156.183.218:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  [FAILED] in [It] - C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/helper/helper_cmd_wrapper.go:101 @ 05/22/23 06:11:45.034
  [odo] Cleaning resources, please wait

...

+ [FAILED] [21.440 seconds]
odo remove binding command tests [BeforeEach] when the component with binding is bootstrapped (bindingName=my-nodejs-app-cluster-sample-ocp) when odo dev is running when binding is removed should have led odo dev to delete ServiceBinding from the cluster
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_remove_binding_test.go:16
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_remove_binding_test.go:71

  Timeline >>
  Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2529226010
  Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2291510114
  Setting KUBECONFIG=C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2291510114\config
  Creating a new project: cmd-remove-binding-test71fxi
  Running oc.exe with args [oc new-project cmd-remove-binding-test71fxi] and odo env: []
  [oc] Unable to connect to the server: dial tcp 158.177.107.50:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

Network issues in 3 out of 4 failures.

The other one was about Persistent Volumes not being bound in a timely manner:


...
+ [FAILED] [549.472 seconds]
odo dev command tests when a component is bootstrapped when Automount volumes are present in the namespace when odo dev is executed [BeforeEach] should mount the volumes
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_dev_test.go:667
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_dev_test.go:678
...
  [odo]  !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
  [odo]  !  AttachVolume.Attach failed for volume "pvc-8625590e-378d-4060-8d87-b659cdcadfb2" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-7331ef70-d3e1-43e7-b270-b44d32829245
  [odo]  !  AttachVolume.Attach failed for volume "pvc-3efa3caa-5d2a-43d2-93bf-4e673e3f0407" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-9aa63bb0-81c2-4ac4-81cf-7672c5bd607f
  [odo]  !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-readonly-pvc auto-pvc-automount-default-pvc], unattached volumes=[odo-shared-data auto-secret-automount-access-mode-subpath-secret auto-secret-automount-mount-path-secret auto-cm-automount-mount-path-configmap auto-pvc-automount-readonly-pvc kube-api-access-ghdgj auto-pvc-automount-mount-path-pvc auto-cm-automount-access-mode-configmap auto-cm-automount-access-mode-configmap-decimal auto-secret-automount-default-secret odo-projects auto-cm-automount-default-configmap auto-secret-automount-subpath-secret auto-pvc-automount-default-pvc auto-cm-automount-access-mode-subpath-configmap auto-cm-automount-subpath-configmap auto-secret-automount-access-mode-secret]: timed out waiting for the condition
  [odo]  !  AttachVolume.Attach failed for volume "pvc-3efa3caa-5d2a-43d2-93bf-4e673e3f0407" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-9aa63bb0-81c2-4ac4-81cf-7672c5bd607f
  [odo]  !  AttachVolume.Attach failed for volume "pvc-8625590e-378d-4060-8d87-b659cdcadfb2" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-7331ef70-d3e1-43e7-b270-b44d32829245
  [odo]  !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-default-pvc auto-pvc-automount-readonly-pvc], unattached volumes=[odo-shared-data auto-secret-automount-subpath-secret auto-secret-automount-mount-path-secret auto-pvc-automount-mount-path-pvc auto-secret-automount-default-secret auto-secret-automount-access-mode-secret auto-cm-automount-default-configmap auto-secret-automount-access-mode-subpath-secret auto-pvc-automount-default-pvc auto-cm-automount-subpath-configmap auto-cm-automount-access-mode-subpath-configmap kube-api-access-ghdgj auto-cm-automount-access-mode-configmap auto-pvc-automount-readonly-pvc auto-cm-automount-mount-path-configmap auto-cm-automount-access-mode-configmap-decimal odo-projects]: timed out waiting for the condition
  [odo]  !  AttachVolume.Attach failed for volume "pvc-3efa3caa-5d2a-43d2-93bf-4e673e3f0407" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-9aa63bb0-81c2-4ac4-81cf-7672c5bd607f
  [odo]  !  AttachVolume.Attach failed for volume "pvc-8625590e-378d-4060-8d87-b659cdcadfb2" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-7331ef70-d3e1-43e7-b270-b44d32829245
  [odo]  !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-readonly-pvc auto-pvc-automount-default-pvc], unattached volumes=[auto-secret-automount-default-secret auto-cm-automount-access-mode-subpath-configmap kube-api-access-ghdgj auto-cm-automount-default-configmap auto-pvc-automount-mount-path-pvc auto-cm-automount-mount-path-configmap odo-projects auto-pvc-automount-readonly-pvc auto-cm-automount-access-mode-configmap-decimal auto-secret-automount-mount-path-secret auto-secret-automount-subpath-secret auto-secret-automount-access-mode-secret auto-cm-automount-access-mode-configmap odo-shared-data auto-pvc-automount-default-pvc auto-secret-automount-access-mode-subpath-secret auto-cm-automount-subpath-configmap]: timed out waiting for the condition
  [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/helper/helper_run.go:54 @ 05/22/23 06:24:34.433

Overriding because all those tests passed in the previous run (with the same changes).

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

Details

In response to this:

+ [FAILED] [21.463 seconds]
odo delete command tests [BeforeEach] when a component is bootstrapped using a devfile.yaml with URI-referenced Kubernetes components when the component is running in both DEV and DEPLOY mode and dev mode is killed when the component is deleted while having access to the devfile.yaml should delete the appropriate resources
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_delete_test.go:25
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_delete_test.go:625

 Timeline >>
 Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\1356430847
 Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\4066833606
 Setting KUBECONFIG=C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\4066833606\config
 Creating a new project: cmd-delete-test625txw
 Running oc.exe with args [oc new-project cmd-delete-test625txw] and odo env: []
 [oc] Unable to connect to the server: dial tcp 149.81.180.114:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
 [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/helper/helper_cmd_wrapper.go:101 @ 05/22/23 06:06:25.182
 Setting current dir to: 
 [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/helper/helper_filesystem.go:90 @ 05/22/23 06:06:25.184
 << Timeline

...
 Running oc.exe with args [oc get pods --namespace cmd-dev-test2781rgp --selector=component=javaspringboot-vnnlcc -o jsonpath={.items[*].metadata.name}] and odo env: []
 [oc] javaspringboot-vnnlcc-app-6f985c85fb-rh4bfRunning oc.exe with args [oc exec javaspringboot-vnnlcc-app-6f985c85fb-rh4bf --namespace cmd-dev-test2781rgp -c runtime -- bash -c grep [s]pring-boot:run /proc/*/cmdline] and odo env: []
 [oc] Unable to connect to the server: dial tcp 161.156.183.218:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
 [FAILED] in [It] - C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/helper/helper_cmd_wrapper.go:101 @ 05/22/23 06:11:45.034
 [odo] Cleaning resources, please wait

...

+ [FAILED] [21.440 seconds]
odo remove binding command tests [BeforeEach] when the component with binding is bootstrapped (bindingName=my-nodejs-app-cluster-sample-ocp) when odo dev is running when binding is removed should have led odo dev to delete ServiceBinding from the cluster
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_remove_binding_test.go:16
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_remove_binding_test.go:71

 Timeline >>
 Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2529226010
 Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2291510114
 Setting KUBECONFIG=C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2291510114\config
 Creating a new project: cmd-remove-binding-test71fxi
 Running oc.exe with args [oc new-project cmd-remove-binding-test71fxi] and odo env: []
 [oc] Unable to connect to the server: dial tcp 158.177.107.50:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

Network issues in 3 out of 4 failures.

The other one was about Persistent Volumes not being bound in a timely manner:


...
+ [FAILED] [549.472 seconds]
odo dev command tests when a component is bootstrapped when Automount volumes are present in the namespace when odo dev is executed [BeforeEach] should mount the volumes
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_dev_test.go:667
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/integration/cmd_dev_test.go:678
...
 [odo]  !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
 [odo]  !  AttachVolume.Attach failed for volume "pvc-8625590e-378d-4060-8d87-b659cdcadfb2" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-7331ef70-d3e1-43e7-b270-b44d32829245
 [odo]  !  AttachVolume.Attach failed for volume "pvc-3efa3caa-5d2a-43d2-93bf-4e673e3f0407" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-9aa63bb0-81c2-4ac4-81cf-7672c5bd607f
 [odo]  !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-readonly-pvc auto-pvc-automount-default-pvc], unattached volumes=[odo-shared-data auto-secret-automount-access-mode-subpath-secret auto-secret-automount-mount-path-secret auto-cm-automount-mount-path-configmap auto-pvc-automount-readonly-pvc kube-api-access-ghdgj auto-pvc-automount-mount-path-pvc auto-cm-automount-access-mode-configmap auto-cm-automount-access-mode-configmap-decimal auto-secret-automount-default-secret odo-projects auto-cm-automount-default-configmap auto-secret-automount-subpath-secret auto-pvc-automount-default-pvc auto-cm-automount-access-mode-subpath-configmap auto-cm-automount-subpath-configmap auto-secret-automount-access-mode-secret]: timed out waiting for the condition
 [odo]  !  AttachVolume.Attach failed for volume "pvc-3efa3caa-5d2a-43d2-93bf-4e673e3f0407" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-9aa63bb0-81c2-4ac4-81cf-7672c5bd607f
 [odo]  !  AttachVolume.Attach failed for volume "pvc-8625590e-378d-4060-8d87-b659cdcadfb2" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-7331ef70-d3e1-43e7-b270-b44d32829245
 [odo]  !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-default-pvc auto-pvc-automount-readonly-pvc], unattached volumes=[odo-shared-data auto-secret-automount-subpath-secret auto-secret-automount-mount-path-secret auto-pvc-automount-mount-path-pvc auto-secret-automount-default-secret auto-secret-automount-access-mode-secret auto-cm-automount-default-configmap auto-secret-automount-access-mode-subpath-secret auto-pvc-automount-default-pvc auto-cm-automount-subpath-configmap auto-cm-automount-access-mode-subpath-configmap kube-api-access-ghdgj auto-cm-automount-access-mode-configmap auto-pvc-automount-readonly-pvc auto-cm-automount-mount-path-configmap auto-cm-automount-access-mode-configmap-decimal odo-projects]: timed out waiting for the condition
 [odo]  !  AttachVolume.Attach failed for volume "pvc-3efa3caa-5d2a-43d2-93bf-4e673e3f0407" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-9aa63bb0-81c2-4ac4-81cf-7672c5bd607f
 [odo]  !  AttachVolume.Attach failed for volume "pvc-8625590e-378d-4060-8d87-b659cdcadfb2" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-7331ef70-d3e1-43e7-b270-b44d32829245
 [odo]  !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-readonly-pvc auto-pvc-automount-default-pvc], unattached volumes=[auto-secret-automount-default-secret auto-cm-automount-access-mode-subpath-configmap kube-api-access-ghdgj auto-cm-automount-default-configmap auto-pvc-automount-mount-path-pvc auto-cm-automount-mount-path-configmap odo-projects auto-pvc-automount-readonly-pvc auto-cm-automount-access-mode-configmap-decimal auto-secret-automount-mount-path-secret auto-secret-automount-subpath-secret auto-secret-automount-access-mode-secret auto-cm-automount-access-mode-configmap odo-shared-data auto-pvc-automount-default-pvc auto-secret-automount-access-mode-subpath-secret auto-cm-automount-subpath-configmap]: timed out waiting for the condition
 [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3981/tests/helper/helper_run.go:54 @ 05/22/23 06:24:34.433

Overriding because all those tests passed in the previous run (with the same changes).

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ec747b4 into redhat-developer:main May 22, 2023
@rm3l rm3l deleted the 6677-image-name-as-selector-implementation-in-odo branch May 22, 2023 14:46
@rm3l rm3l mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kadel kadel Awaiting requested review from kadel

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

1 more reviewer

@feloy feloy feloy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@feloy feloy

Labels

area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Image name as selector: implementation in odo

3 participants

@rm3l @feloy @openshift-merge-robot