Test flaky devfile modification test#6769
Merged
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom Apr 26, 2023
Merged
Test flaky devfile modification test#6769openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
openshift-ci
bot
added
area/testing
valaparthvi
force-pushed
the
flake-modification-test
branch
from
b969bd4 to
36dafad
Compare
openshift-merge-robot
added
the
needs-rebase
valaparthvi
force-pushed
the
flake-modification-test
branch
from
bfaf3ed to
cbe4968
Compare
openshift-merge-robot
removed
the
needs-rebase
feloy
reviewed
Apr 25, 2023
Contributor
Author
[FAILED] user-guides/quickstart/docs-mdx/nodejs/nodejs_odo_dev_output.mdx
Expected
<string>: Â Â (
  """
  ... // 9 identical lines
  • Waiting for Kubernetes resources ...
  ⚠Pod is Pending
- ✓ Pod is Running
  ✓ Syncing files into the container [1s]
  ✓ Building your application in container (command: install) [1s]
  ... // 10 identical lines
  [Ctrl+c] - Exit and delete resources from the cluster
  [p] - Manually apply local changes to the application on the cluster
+ ✓ Pod is Running
  ```
  """
  )
to be empty
In [It] at: /go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:104 @ 04/25/23 12:18:22.625
------------------------------
Spawning '/go/bin/odo init' from /tmp/3354671968/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests |
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
LGTM |
Signed-off-by: Parthvi Vala <[email protected]> Co-authored-by: Philippe Martin <[email protected]> Co-authored-by: Armel Soro <[email protected]> Move test skip before waitgroup is initiated Signed-off-by: Parthvi Vala <[email protected]>
valaparthvi
force-pushed
the
flake-modification-test
branch
from
ec67dea to
38f6506
Compare
valaparthvi
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
/override windows-integration-test/Windows-test Tests pass previously |
|
@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
Thanks @valaparthvi for this fix |
Contributor
Author
|
@feloy can you approve this PR? |
Contributor
|
/lgtm Sorry, I thought I approved it when overriding the tests |
openshift-ci
bot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/area testing
/kind bug
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6601
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: