✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	50cee02
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6450b79c4c712f0008d3135b
😎 Deploy Preview	https://deploy-preview-6771--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

OpenShift Unauthenticated Tests on commit 491337b finished successfully.
View logs: TXT HTML

NoCluster Tests on commit 491337b finished successfully.
View logs: TXT HTML

Unit Tests on commit 491337b finished successfully.
View logs: TXT HTML

Validate Tests on commit 491337b finished successfully.
View logs: TXT HTML

Kubernetes Tests on commit 491337b finished successfully.
View logs: TXT HTML

OpenShift Tests on commit 491337b finished with errors.
View logs: TXT HTML

Windows Tests (OCP) on commit 491337b finished successfully.
View logs: TXT HTML

Kubernetes Docs Tests on commit 0a8500d finished successfully.
View logs: TXT HTML

Nothing happened after pressing p (I tried multiple times at different intervals to check). It works as expected on Podman however.
Is it just me?

It works for me on K8s cluster. But were you using a different kind of project? I used the normal starter project to test this. I need to test it a little extensively, I think.

$ odo dev --debug --no-watch
  __
 /  \__     Developing using the "my-nodejs-app" Devfile
 \__/  \    Namespace: default
 /  \__/    odo version: v3.9.0
 \__/

 ⚠  You are using "default" namespace, odo may not work as expected in the default namespace.
 ⚠  You may set a new namespace by running `odo create namespace <name>`, or set an existing one by running `odo set namespace <name>`

↪ Running on the cluster in Dev mode
 •  Waiting for Kubernetes resources  ...
 ⚠  Pod is Pending
 ✓  Pod is Running
 ✓  Syncing files into the container [138ms]
 ✓  Building your application in container (command: install) [1s]
 •  Executing the application (command: debug)  ...
 ✓  Waiting for the application to be ready [1s]
 -  Forwarding from 127.0.0.1:20001 -> 3000

 -  Forwarding from 127.0.0.1:20002 -> 5858


↪ Dev mode
 Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster
pPushing files...

 •  Waiting for Kubernetes resources  ...
 ✓  Syncing files into the container [65ms]
 ✓  Building your application in container (command: install) [789ms]
 ✗  Finished executing the application (command: debug) [35s]
 •  Executing the application (command: debug)  ...
 ✓  Waiting for the application to be ready [1s]

↪ Dev mode
 Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster

But, it does not work if I modify the Devfile. I started with an invalid npm install-non command in my devfile, odo stopped when it encountered the error. Then I modified the devfile, and pressed p, but nothing happened.

$ odo dev --debug --no-watch
  __
 /  \__     Developing using the "my-nodejs-app" Devfile
 \__/  \    Namespace: default
 /  \__/    odo version: v3.9.0
 \__/

 ⚠  You are using "default" namespace, odo may not work as expected in the default namespace.
 ⚠  You may set a new namespace by running `odo create namespace <name>`, or set an existing one by running `odo set namespace <name>`

↪ Running on the cluster in Dev mode
 •  Waiting for Kubernetes resources  ...
 ⚠  Pod is Pending
 ✓  Pod is Running
 ✓  Syncing files into the container [131ms]
 ✗  Building your application in container (command: install) [232ms]
Unknown command: "install-non-existent"

To see a list of supported npm commands, run:
  npm help
Error occurred on Push - watch command was unable to push component: unable to exec command [/bin/sh -c cd ${PROJECT_SOURCE} && (npm install-non-existent) 1>>/proc/1/fd/1 2>>/proc/1/fd/2]: error while streaming command: command terminated with exit code 1


↪ Dev mode
 Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster
pp
p

It works great overall - thanks for this refactoring!

One thing I just noticed: when the build command fails on Kubernetes, odo dev displays the logs and waits (which is expected); but when I tried pressing p, but it did not retrigger the sync..

$ odo dev --debug --no-watch
  __
 /  \__     Developing using the "my-nodejs" Devfile
 \__/  \    Namespace: default
 /  \__/    odo version: v3.9.0
 \__/

 ⚠  You are using "default" namespace, odo may not work as expected in the default namespace.
 ⚠  You may set a new namespace by running `odo create namespace <name>`, or set an existing one by running `odo set namespace <name>`

↪ Running on the cluster in Dev mode
 •  Waiting for Kubernetes resources  ...
 ⚠  Pod is Pending
 ✓  Pod is Running
 ✓  Syncing files into the container [132ms]
 ✗  Building your application in container (command: install) [57ms]
Exiting...
Error occurred on Push - watch command was unable to push component: unable to exec command [/bin/sh -c cd ${PROJECT_SOURCE} && (echo Exiting... && exit 1 && npm install) 1>>/proc/1/fd/1 2>>/proc/1/fd/2]: error while streaming command: command terminated with exit code 1


↪ Dev mode
 Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster
p

Nothing happened after pressing p (I tried multiple times at different intervals to check). It works as expected on Podman however. Is it just me?

I have made a fix. thanks for the catch

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Nothing happened after pressing p (I tried multiple times at different intervals to check). It works as expected on Podman however.
Is it just me?

It works for me on K8s cluster. But were you using a different kind of project? I used the normal starter project to test this. I need to test it a little extensively, I think.

Yes, the normal case worked fine for me as well. I tested the second case you mentioned below (which was the scope of the related issue): a Devfile with a failing build command..
But it is working now with the latest commits.

Details
But, it does not work if I modify the Devfile. I started with an invalid npm install-non command in my devfile, odo stopped when it encountered the error. Then I modified the devfile, and pressed p, but nothing happened.

Details

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [169.775 seconds]
odo remove binding command tests when the component with binding is bootstrapped (bindingName=my-nodejs-app-cluster-sample-ocp) when odo dev is running when binding is removed [It] should have led odo dev to delete ServiceBinding from the cluster
/go/odo_1/tests/integration/cmd_remove_binding_test.go:71

[...]

[odo] I0502 07:47:27.510696    6779 exec.go:49] ExecuteCommand returned an an err: error while streaming command: error sending request: Post "[https://c100-e.eu-de.containers.cloud.ibm.com:31049/api/v1/namespaces/cmd-remove-binding-test71ook/pods/mynode-app-6f4678f6db-bx42v/exec?command=%2Fbin%2Fsh&command=-c&command=cat+%2Fopt%2Fodo%2F.odo_cmd_run.pid+%7C%7C+true&container=runtime&stderr=true&stdout=true":](https://c100-e.eu-de.containers.cloud.ibm.com:31049/api/v1/namespaces/cmd-remove-binding-test71ook/pods/mynode-app-6f4678f6db-bx42v/exec?command=%2Fbin%2Fsh&command=-c&command=cat+%2Fopt%2Fodo%2F.odo_cmd_run.pid+%7C%7C+true&container=runtime&stderr=true&stdout=true%22:) dial tcp: lookup c100-e.eu-de.containers.cloud.ibm.com: operation was canceled. for command '[/bin/sh -c cat /opt/odo/.odo_cmd_run.pid || true]'

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests