PODMAN_USE_NAMESPACES to disable using namespaces on podman integration tests for podman v4.5#6774
Conversation
…on tests for podman v4.5
openshift-ci
bot
added
the
area/testing
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
rm3l
left a comment
rm3l
left a comment
There was a problem hiding this comment.
Thanks for this! I'll check the workaround suggested by the Podman folks to isolate the tests, to see if that helps.
openshift-ci
bot
added
the
lgtm
tests/helper/helper_podman.go
Outdated
| ) | ||
|
|
||
| func GenerateAndSetContainersConf(dir string) { | ||
| if os.Getenv("PODMAN_USE_NAMESPACES") == "false" { |
There was a problem hiding this comment.
I believe this can be a workaround for #6773 as well.
tests/helper/helper_podman.go
Outdated
| ) | ||
|
|
||
| func GenerateAndSetContainersConf(dir string) { | ||
| if os.Getenv("PODMAN_USE_NAMESPACES") == "false" { |
There was a problem hiding this comment.
| if os.Getenv("PODMAN_USE_NAMESPACES") == "false" { | |
| useNamespace, _ := strconv.ParseBool(os.Getenv("PODMAN_USE_NAMESPACES")) | |
| if !useNamespace { |
openshift-ci
bot
removed
the
lgtm
Co-authored-by: Parthvi Vala <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
openshift-ci
bot
added
the
lgtm
|
/override windows-integration-test/Windows-test |
|
@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests, windows-integration-test/Windows-test DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ntegration tests for podman v4.5 (redhat-developer#6774)" We'll completely remove the usage of namespaces in the tests, as this wad removed from Podman v4.5.0, because namespaces on Podman were reportedly not really working [1]. This reverts commit ef9206a. [1] containers/podman@c4fe0af
4 participants
What type of PR is this:
This PR introduces a new env var for integration tests: PODMAN_USE_NAMESPACES
This is useful when running podman tests on a local system with podman v4.5.0, as namespace feature has been removed from podman v4.5
(tests on github actions are not impacted because running on podman v3)
When using this option, you need to take care of not running tests in parallel, or some tests could fail.
Ex:
/area testing
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6773
6773 was not the original issue, but this PR still fixes it./=
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: