Add spinner when determining a devfile using alizer#6793
Merged
openshift-merge-robot merged 5 commits intoredhat-developer:mainfrom May 16, 2023
Merged
Add spinner when determining a devfile using alizer#6793openshift-merge-robot merged 5 commits intoredhat-developer:mainfrom
openshift-merge-robot merged 5 commits intoredhat-developer:mainfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
valaparthvi
force-pushed
the
6780-add-spinner
branch
from
3530607 to
49e5d77
Compare
valaparthvi
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
valaparthvi
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
valaparthvi
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
valaparthvi
force-pushed
the
6780-add-spinner
branch
from
78285d9 to
9ddac8a
Compare
…on odo dev Signed-off-by: Parthvi Vala <[email protected]>
…ackend Select Devfile Co-authored-by: Philippe Martin <[email protected]> Co-authored-by: Armel Soro <[email protected]> Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
valaparthvi
force-pushed
the
6780-add-spinner
branch
from
9ddac8a to
afa839b
Compare
rm3l
approved these changes
May 15, 2023
openshift-ci
bot
added
the
lgtm
Signed-off-by: Parthvi Vala <[email protected]>
valaparthvi
force-pushed
the
6780-add-spinner
branch
from
afa839b to
82ebfe5
Compare
openshift-ci
bot
removed
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests |
|
@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
/lgtm |
openshift-ci
bot
added
the
lgtm
Contributor
|
/override kubernetes-infra-stage-test |
|
@feloy: Overrode contexts on behalf of feloy: kubernetes-infra-stage-test DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6780
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
TODO: Fix panic on Ctrl+c with
odo dev