Skip to content

Updating the oudated release script#6801

Merged
openshift-merge-robot merged 9 commits intoredhat-developer:mainfrom
ritudes:issue/#6730
May 23, 2023
Merged

Updating the oudated release script#6801
openshift-merge-robot merged 9 commits intoredhat-developer:mainfrom
ritudes:issue/#6730

Conversation

@ritudes
Copy link
Contributor

@ritudes ritudes commented May 9, 2023

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6730

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 9, 2023
@netlify
Copy link

netlify bot commented May 9, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 508e049
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/646c93596a3b320008973dca

@openshift-ci openshift-ci bot requested review from anandrkskd and rnapoles-rh May 9, 2023 08:08
@ritudes ritudes requested a review from rm3l May 9, 2023 08:08
@odo-robot
Copy link

odo-robot bot commented May 9, 2023 •
edited
Loading

NoCluster Tests on commit 041e7f1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 041e7f1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023 •
edited
Loading

Unit Tests on commit 041e7f1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023 •
edited
Loading

Validate Tests on commit 041e7f1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023 •
edited
Loading

Kubernetes Tests on commit 041e7f1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023 •
edited
Loading

Windows Tests (OCP) on commit 041e7f1 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023 •
edited
Loading

OpenShift Tests on commit 041e7f1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 58969d9 finished successfully.
View logs: TXT HTML

@ritudes ritudes closed this May 9, 2023
@ritudes ritudes reopened this May 9, 2023
rm3l
rm3l requested changes May 10, 2023
View reviewed changes
@ritudes ritudes removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 11, 2023
@ritudes ritudes changed the title [WIP]Updating the oudated release script Updating the oudated release script May 11, 2023
rm3l
rm3l requested changes May 11, 2023
View reviewed changes
@ritudes ritudes requested a review from rm3l May 23, 2023 07:19
rm3l
rm3l reviewed May 23, 2023
View reviewed changes
scripts/release-bit-verification.sh Outdated
WORKING_DIR=$(mktemp -d)
shout "WORKING_DIR=$WORKING_DIR"
export REPO_URL=${REPO_URL:-"https://github.com/redhat-developer/odo.git"}
if [ -f ${1} ];
Copy link
Member

@rm3l rm3l May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would still create the temporary directory if the file is not valid.
I'd suggest inverting the condition: exit if the file does not exist, without even creating the temporary directory.

Once all checks are done on the first argument, we can proceed with creating the temporary directory.

@ritudes ritudes closed this May 23, 2023
@ritudes ritudes reopened this May 23, 2023
@ritudes ritudes closed this May 23, 2023
@ritudes ritudes reopened this May 23, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rm3l
rm3l approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 23, 2023
@rm3l
Copy link
Member

rm3l commented May 23, 2023

Unrelated.

/override ODO-PODMAN-TEST

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

@rm3l: Overrode contexts on behalf of rm3l: ODO-PODMAN-TEST

Details

In response to this:

Unrelated.

/override ODO-PODMAN-TEST

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented May 23, 2023 

[odo]  X  unable to detect project support: Get "[https://c114-e.eu-de.containers.cloud.ibm.com:30329/apis/project.openshift.io/v1?timeout=32s":](https://c114-e.eu-de.containers.cloud.ibm.com:30329/apis/project.openshift.io/v1?timeout=32s%22:) dial tcp 161.156.183.218:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  [FAILED] in [It] - C:/Users/Administrator.ANSIBLE-TEST-VS/4001/tests/helper/helper_cmd_wrapper.go:101 @ 05/23/23 08:04:24.29
  Deleting project: cmd-namespace-test196poe
  Running oc.exe with args [oc delete project cmd-namespace-test196poe --wait=false] and odo env: []
  [oc] project.project.openshift.io "cmd-namespace-test196poe" deleted
  Setting current dir to: C:\Users\Administrator.ANSIBLE-TEST-VS\4001\tests\integration
  Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3315007015
  Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\4162654821
  << Timeline

  [FAILED] No future change is possible.  Bailing out early after 21.191s.
  Running odo.exe with args [odo list project] and odo env: []
  Expected
      <int>: 1
  to match exit code:
      <int>: 0
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4001/tests/helper/helper_cmd_wrapper.go:101 @ 05/23/23 08:04:24.29

...

Summarizing 1 Failure:
  [FAIL] odo create/delete/list/set namespace/project tests list project [It] should successfully list all the projects
  C:/Users/Administrator.ANSIBLE-TEST-VS/4001/tests/helper/helper_cmd_wrapper.go:101

Ran 472 of 885 Specs in 1643.397 seconds
FAIL! -- 471 Passed | 1 Failed | 0 Pending | 413 Skipped

Network issues on Windows - tracked in #6838

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

Details

In response to this:

[odo]  X  unable to detect project support: Get "[https://c114-e.eu-de.containers.cloud.ibm.com:30329/apis/project.openshift.io/v1?timeout=32s&quot;:](https://c114-e.eu-de.containers.cloud.ibm.com:30329/apis/project.openshift.io/v1?timeout=32s%22:) dial tcp 161.156.183.218:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
 [FAILED] in [It] - C:/Users/Administrator.ANSIBLE-TEST-VS/4001/tests/helper/helper_cmd_wrapper.go:101 @ 05/23/23 08:04:24.29
 Deleting project: cmd-namespace-test196poe
 Running oc.exe with args [oc delete project cmd-namespace-test196poe --wait=false] and odo env: []
 [oc] project.project.openshift.io "cmd-namespace-test196poe" deleted
 Setting current dir to: C:\Users\Administrator.ANSIBLE-TEST-VS\4001\tests\integration
 Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3315007015
 Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\4162654821
 << Timeline

 [FAILED] No future change is possible.  Bailing out early after 21.191s.
 Running odo.exe with args [odo list project] and odo env: []
 Expected
     <int>: 1
 to match exit code:
     <int>: 0
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4001/tests/helper/helper_cmd_wrapper.go:101 @ 05/23/23 08:04:24.29

...

Summarizing 1 Failure:
 [FAIL] odo create/delete/list/set namespace/project tests list project [It] should successfully list all the projects
 C:/Users/Administrator.ANSIBLE-TEST-VS/4001/tests/helper/helper_cmd_wrapper.go:101

Ran 472 of 885 Specs in 1643.397 seconds
FAIL! -- 471 Passed | 1 Failed | 0 Pending | 413 Skipped

Network issues on Windows - tracked in #6838

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l added kind/bug Categorizes issue or PR as related to a bug. area/release-eng Issues or PRs related to the Release Engineering area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels May 23, 2023
@rm3l
Copy link
Member

rm3l commented May 23, 2023

/override ODO-PODMAN-TEST

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

@rm3l: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ODO-PODMAN-TEST

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/odo-ocp4.13-lp-interop-images
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.12-images
  • ci/prow/v4.13-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-odo-ocp4.13-lp-interop-images
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.13-images
  • tide
  • validator/Validate
  • windows-integration-test/Windows-test

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ODO-PODMAN-TEST

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 63bf76a into redhat-developer:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

Assignees

@rm3l rm3l

Labels

area/release-eng Issues or PRs related to the Release Engineering area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix outdated release verification script

3 participants

@ritudes @rm3l @openshift-merge-robot