Do not run 'odo-infra-stage-test' Workflow on PRs if not needed#6823
Merged
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom May 19, 2023
Conversation
… modify any files under 'scripts/ansible'
openshift-ci
bot
added
kind/bug
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Closed
|
Kudos, SonarCloud Quality Gate passed!
|
openshift-ci
bot
added
the
lgtm
Contributor
|
/override ODO-PODMAN-TEST |
|
@feloy: Overrode contexts on behalf of feloy: ODO-PODMAN-TEST DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rm3l
deleted the
6813-infra-ansible-scripts-do-not-run-workflow-unnecessarily-on-prs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
/area infra
/area testing
What does this PR do / why we need it:
Currently, the
odo-infra-stage-testjob runs on all PRs (and ends up failing), even if the PR has not changed anything inscripts/ansible:The job ends up failing and we manually have to override it.
This PR makes sure not to run it if not needed.
There is one additional point related to this job (see #6813 (comment)), but that can be addressed later.
Which issue(s) this PR fixes:
Related to #6813
This way, we won't need to manually override this job on all PRs.
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: