Skip to content

Replace deprecated --slow-spec-threshold Ginkgo flag with --poll-progress-after#6834

Merged
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
rm3l:replace_deprecated_slow-spec-threshold_ginkgo_flag
May 23, 2023
Merged

Replace deprecated --slow-spec-threshold Ginkgo flag with --poll-progress-after#6834
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
rm3l:replace_deprecated_slow-spec-threshold_ginkgo_flag

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented May 22, 2023

What type of PR is this:
/area testing

What does this PR do / why we need it:
Per [1], this instructs Ginkgo to automatically emit a progress report whenever a node takes too long to complete.
The Progress Report includes information about which node is currently running and the exact line of code that it is currently executing, along with any relevant goroutines that were launched by the spec.

[1] https://onsi.github.io/ginkgo/#getting-visibility-into-long-running-specs

Which issue(s) this PR fixes:
Deprecation warnings as seen at the end of all our tests, like here:

Ran 162 of 888 Specs in 1072.811 seconds
SUCCESS! -- [16](https://github.com/redhat-developer/odo/actions/runs/5045832057/jobs/9053658068#step:5:17)2 Passed | 0 Failed | 0 Pending | 726 Skipped


Ginkgo ran 1 suite in [18](https://github.com/redhat-developer/odo/actions/runs/5045832057/jobs/9053658068#step:5:19)m25.223387422s
Test Suite Passed
You're using deprecated Ginkgo functionality:
=============================================
  --slow-spec-threshold is deprecated --slow-spec-threshold has been deprecated and will be removed in a future version of Ginkgo.  This feature has proved to be more noisy than useful.  You can use --poll-progress-after, instead, to get more actionable feedback about potentially slow specs and understand where they might be getting stuck.

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=2.8.0

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@rm3l
Replace deprecated '--slow-spec-threshold' Ginkgo flag with '--poll-p…
cda8dce 
…rogress-after'

Per [1], this instructs Ginkgo to automatically emit a progress report
whenever a node takes too long to complete.
The Progress Report includes information about which node is currently running
and the exact line of code that it is currently executing,
along with any relevant goroutines that were launched by the spec.

[1] https://onsi.github.io/ginkgo/#getting-visibility-into-long-running-specs
@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label May 22, 2023
@netlify
Copy link

netlify bot commented May 22, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit fe03a2d
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/646bd71f7ea79d0008f97a20

@rm3l rm3l added this to the v3.11.0 🚀 milestone May 22, 2023
@openshift-ci openshift-ci bot requested review from kadel and valaparthvi May 22, 2023 16:50
@odo-robot
Copy link

odo-robot bot commented May 22, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 4f53929 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023 •
edited
Loading

NoCluster Tests on commit 4f53929 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023 •
edited
Loading

Unit Tests on commit 4f53929 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023 •
edited
Loading

Validate Tests on commit 4f53929 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023 •
edited
Loading

Kubernetes Tests on commit 4f53929 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023 •
edited
Loading

Windows Tests (OCP) on commit 4f53929 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023 •
edited
Loading

Kubernetes Docs Tests on commit db35b57 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 23, 2023
@valaparthvi
Copy link
Contributor

valaparthvi commented May 23, 2023

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor

valaparthvi commented May 23, 2023

/override ODO-PODMAN-TEST

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: ODO-PODMAN-TEST

Details

In response to this:

/override ODO-PODMAN-TEST

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 58969d9 into redhat-developer:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kadel kadel Awaiting requested review from kadel

1 more reviewer

@valaparthvi valaparthvi valaparthvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@valaparthvi valaparthvi

Labels

area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

v3.11.0 🚀

Development

Successfully merging this pull request may close these issues.

3 participants

@rm3l @valaparthvi @openshift-merge-robot