Skip to content

Track preference options usage#6843

Merged
openshift-merge-robot merged 3 commits intoredhat-developer:mainfrom
rm3l:6791-track-preference-options-usage
May 30, 2023
Merged

Track preference options usage#6843
openshift-merge-robot merged 3 commits intoredhat-developer:mainfrom
rm3l:6791-track-preference-options-usage

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented May 24, 2023

What type of PR is this:
/kind feature
/area telemetry

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #6791

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label May 24, 2023
@netlify
Copy link

netlify bot commented May 24, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit ef58b8e
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64759f506c4249000720db7f

@openshift-ci openshift-ci bot added the area/telemetry Issues or PRs related to telemetry or metrics collection label May 24, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and kadel May 24, 2023 16:35
@rm3l rm3l requested review from feloy and valaparthvi and removed request for anandrkskd May 24, 2023 16:39
@odo-robot
Copy link

odo-robot bot commented May 24, 2023 •
edited
Loading

NoCluster Tests on commit c2634f6 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 24, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit c2634f6 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 24, 2023 •
edited
Loading

Unit Tests on commit c2634f6 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 24, 2023 •
edited
Loading

Validate Tests on commit c2634f6 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 24, 2023 •
edited
Loading

Kubernetes Tests on commit c2634f6 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 24, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 85b4ff9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 24, 2023 •
edited
Loading

Windows Tests (OCP) on commit c2634f6 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 24, 2023 •
edited
Loading

OpenShift Tests on commit c2634f6 finished with errors.
View logs: TXT HTML

feloy
feloy reviewed May 25, 2023
View reviewed changes
@rm3l rm3l requested a review from feloy May 26, 2023 14:11
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 26, 2023
@rm3l
Copy link
Member Author

rm3l commented May 26, 2023 

  [FAILED] Expected
      <*url.Error | 0xc000533410>: {
          Op: "Post",
          URL: "http://127.0.0.1:34017/api/newuser",
          Err: <*errors.errorString | 0xc000072130>{s: "EOF"},
      }
  to be nil
  In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 05/26/23 14:48:08.161
...
------------------------------

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  /go/odo_1/tests/e2escenarios/e2e_test.go:431

Ran 4 of 4 Specs in 257.629 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test - tracked in #6582

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

 [FAILED] Expected
     <*url.Error | 0xc000533410>: {
         Op: "Post",
         URL: "http://127.0.0.1:34017/api/newuser",
         Err: <*errors.errorString | 0xc000072130>{s: "EOF"},
     }
 to be nil
 In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 05/26/23 14:48:08.161
...
------------------------------

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 /go/odo_1/tests/e2escenarios/e2e_test.go:431

Ran 4 of 4 Specs in 257.629 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test - tracked in #6582

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 26, 2023
rm3l and others added 3 commits May 27, 2023 14:45
@rm3l
Add integration test highlighting the expectations
ee69e25
@rm3l
Record parameter (and value) set or unset using the 'odo preference s…
f1cef86 
…et/unset' commands

By default, values are anonymized.
Only parameters explicitly declared list will be recorded verbatim.
This list is currently empty, but that might change later on.
@rm3l @feloy
Mark all current preference parameters except ImageRegistry as clear-…
ef58b8e 
…text

Co-authored-by: Philippe Martin <[email protected]>
@rm3l rm3l force-pushed the 6791-track-preference-options-usage branch from 40b8443 to ef58b8e Compare May 30, 2023 07:01
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 30, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 30, 2023
@rm3l
Copy link
Member Author

rm3l commented May 30, 2023

Force-pushed to fix Git conflicts with the main branch.

@rm3l rm3l requested a review from feloy May 30, 2023 07:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 30, 2023
@feloy
Copy link
Contributor

feloy commented May 30, 2023

/override windows-integration-test/Windows-test

 [FAILED] [547.404 seconds]
odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4041/tests/integration/cmd_dev_test.go:2110
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4041/tests/integration/cmd_dev_test.go:2135


[FAILED] [547.774 seconds]
odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] should have created resources
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4041/tests/integration/cmd_dev_test.go:510
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4041/tests/integration/cmd_dev_test.go:529

  [odo]  !  AttachVolume.Attach failed for volume "pvc-1c04aca2-5f62-432c-b154-c9ac0061c4fc" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-3f834e80-4f09-4afe-b832-5e9a2f03701b
  [odo]  !  Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[kube-api-access-8v5nr odo-projects odo-shared-data]: timed out waiting for the condition

@openshift-ci
Copy link

openshift-ci bot commented May 30, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test

[FAILED] [547.404 seconds]
odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4041/tests/integration/cmd_dev_test.go:2110
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4041/tests/integration/cmd_dev_test.go:2135


[FAILED] [547.774 seconds]
odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] should have created resources
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4041/tests/integration/cmd_dev_test.go:510
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4041/tests/integration/cmd_dev_test.go:529

 [odo]  !  AttachVolume.Attach failed for volume "pvc-1c04aca2-5f62-432c-b154-c9ac0061c4fc" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-3f834e80-4f09-4afe-b832-5e9a2f03701b
 [odo]  !  Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[kube-api-access-8v5nr odo-projects odo-shared-data]: timed out waiting for the condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented May 30, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [82.111 seconds]
E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
/go/odo_1/tests/e2escenarios/e2e_test.go:462

@openshift-ci
Copy link

openshift-ci bot commented May 30, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [82.111 seconds]
E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
/go/odo_1/tests/e2escenarios/e2e_test.go:462

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a79c953 into redhat-developer:main May 30, 2023
@rm3l rm3l deleted the 6791-track-preference-options-usage branch May 30, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kadel kadel Awaiting requested review from kadel

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

1 more reviewer

@feloy feloy feloy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@feloy feloy

Labels

area/telemetry Issues or PRs related to telemetry or metrics collection kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

track preference options usage

3 participants

@rm3l @feloy @openshift-merge-robot