Skip to content

Bump Devfile library to latest commit (04a8b3f)#6845

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
rm3l:bump_devfile_library_to_04a8b3fc66c0
May 26, 2023
Merged

Bump Devfile library to latest commit (04a8b3f)#6845
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
rm3l:bump_devfile_library_to_04a8b3fc66c0

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented May 25, 2023

What type of PR is this:
/area dependency

What does this PR do / why we need it:
This bumps the Devfile library to the latest commit [1], which fixes the issue with parsing child Devfiles
referencing parents via URIs (GitHub blob, raw or any hosted URL).
See [2] for more context.

[1] devfile/library@04a8b3f
[2] devfile/api#1119

Which issue(s) this PR fixes:
Related to devfile/api#1119

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Given the following Devfile:

metadata:
  description: Java application using Spring Boot® and OpenJDK 17
  name: my-java-sb
  version: 1.3.0
parent:
  components:
  - container:
      image: registry.access.redhat.com/ubi9/openjdk-17:latest
    name: tools
  uri: https://registry.stage.devfile.io/devfiles/java-springboot/1.2.0
schemaVersion: 2.1.0

Before this PR, odo dev won't be able to parse it:

$ odo dev
 ✗  failed to parse the devfile /tmp/bug-odo-parent/devfile.yaml: failed to populateAndParseDevfile: url host should be a valid GitHub, GitLab, or Bitbucket host; received: registry.stage.devfile.io

It should now work with this update of the Devfile library:

$ odo dev
  __
 /  \__     Developing using the "my-java-sb" Devfile
 \__/  \    Namespace: default
 /  \__/    odo version: v3.10.0
 \__/

 ⚠  You are using "default" namespace, odo may not work as expected in the default namespace.
 ⚠  You may set a new namespace by running `odo create namespace <name>`, or set an existing one by running `odo set namespace <name>`

↪ Running on the cluster in Dev mode
 •  Waiting for Kubernetes resources  ...
 ✓  Added storage m2 to component
 ⚠  Pod is Pending

...

@rm3l
Bump Devfile library to latest commit [1]
6f4988b 
This fixes the issue with parsing child Devfiles
referencing parents via URIs (GitHub blob, raw or any hosted URL).
See [2] for more context.

[1] devfile/library@04a8b3f
[2] devfile/api#1119
@netlify
Copy link

netlify bot commented May 25, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 6f4988b
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/646f8a2955c05c0009db7701

@openshift-ci openshift-ci bot added the area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs label May 25, 2023
@openshift-ci openshift-ci bot requested review from kadel and valaparthvi May 25, 2023 16:18
@rm3l rm3l added this to the v3.11.0 🚀 milestone May 25, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented May 25, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 25, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 25, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 25, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 25, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 25, 2023

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 25, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 25, 2023

Kubernetes Docs Tests on commit dcbc60a finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 26, 2023
@feloy
Copy link
Contributor

feloy commented May 26, 2023

/override windows-integration-test/Windows-test

  [odo]  !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-mount-path-pvc auto-pvc-automount-readonly-pvc], unattached volumes=[kube-api-access-kb2qd odo-shared-data auto-secret-automount-access-mode-secret auto-cm-automount-access-mode-subpath-configmap auto-pvc-automount-default-pvc auto-cm-automount-access-mode-configmap auto-cm-automount-default-configmap auto-cm-automount-subpath-configmap auto-secret-automount-subpath-secret odo-projects auto-pvc-automount-mount-path-pvc auto-cm-automount-access-mode-configmap-decimal auto-secret-automount-default-secret auto-secret-automount-mount-path-secret auto-secret-automount-access-mode-subpath-secret auto-cm-automount-mount-path-configmap auto-pvc-automount-readonly-pvc]: timed out waiting for the condition

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test

 [odo]  !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-mount-path-pvc auto-pvc-automount-readonly-pvc], unattached volumes=[kube-api-access-kb2qd odo-shared-data auto-secret-automount-access-mode-secret auto-cm-automount-access-mode-subpath-configmap auto-pvc-automount-default-pvc auto-cm-automount-access-mode-configmap auto-cm-automount-default-configmap auto-cm-automount-subpath-configmap auto-secret-automount-subpath-secret odo-projects auto-pvc-automount-mount-path-pvc auto-cm-automount-access-mode-configmap-decimal auto-secret-automount-default-secret auto-secret-automount-mount-path-secret auto-secret-automount-access-mode-subpath-secret auto-cm-automount-mount-path-configmap auto-pvc-automount-readonly-pvc]: timed out waiting for the condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 2336042 into redhat-developer:main May 26, 2023
@rm3l rm3l deleted the bump_devfile_library_to_04a8b3fc66c0 branch May 26, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kadel kadel Awaiting requested review from kadel

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

1 more reviewer

@feloy feloy feloy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@feloy feloy

Labels

area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

v3.11.0 🚀

Development

Successfully merging this pull request may close these issues.

3 participants

@rm3l @feloy @openshift-merge-robot