Skip to content

Add podman version to odo version output#6913

Merged
openshift-merge-robot merged 7 commits intoredhat-developer:mainfrom
valaparthvi:6806-provide-support-in-odo-version-for-podman
Jun 24, 2023
Merged

Add podman version to odo version output#6913
openshift-merge-robot merged 7 commits intoredhat-developer:mainfrom
valaparthvi:6806-provide-support-in-odo-version-for-podman

Conversation

@valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Jun 19, 2023

What type of PR is this:
/kind feature

What does this PR do / why we need it:
This PR adds podman version (if available) to the odo version output.
Which issue(s) this PR fixes:

Fixes #6806

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 19, 2023
@netlify
Copy link

netlify bot commented Jun 19, 2023 •
edited by github-actions bot
Loading

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit 93618eb
😎 Deploy Preview https://odo-dev-pr-6913.odo-test-kubernetes-clust-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jun 19, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and feloy June 19, 2023 12:34
@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

Windows Tests (OCP) on commit 8a30908 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 8a30908 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

NoCluster Tests on commit 8a30908 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

Unit Tests on commit 8a30908 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

Validate Tests on commit 8a30908 finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi force-pushed the 6806-provide-support-in-odo-version-for-podman branch from 0d5932d to 0acf1a5 Compare June 19, 2023 12:51
@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

Kubernetes Tests on commit 8a30908 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

OpenShift Tests on commit 8a30908 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

Kubernetes Docs Tests on commit ae28de1 finished with errors.
View logs: TXT HTML

@valaparthvi valaparthvi force-pushed the 6806-provide-support-in-odo-version-for-podman branch from 011b722 to ea2d256 Compare June 20, 2023 10:04
@valaparthvi valaparthvi temporarily deployed to internal June 20, 2023 12:27 — with GitHub Actions Inactive
@valaparthvi valaparthvi changed the title WIP: Add podman version to odo version output Add podman version to odo version output Jun 20, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 20, 2023
@valaparthvi valaparthvi requested review from rm3l and removed request for anandrkskd June 20, 2023 15:03
@valaparthvi
Copy link
Contributor Author

valaparthvi commented Jun 20, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Unrelated failure.

@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Unrelated failure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi valaparthvi temporarily deployed to internal June 21, 2023 12:47 — with GitHub Actions Inactive
rm3l
rm3l requested changes Jun 22, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment about the --client option: we are displaying warnings when a user specifies --client, but I think this can be quite confusing.

$ odo version --client        
 ⚠  unable to fetch the cluster server version
 ⚠  unable to fetch the podman client version
odo v3.11.0 (8e0cd5a80)

As a user, I'd expect to not even check Podman and clusters, so I think we should not display those warnings, no?

@valaparthvi valaparthvi temporarily deployed to internal June 22, 2023 09:29 — with GitHub Actions Inactive
@valaparthvi valaparthvi requested a review from rm3l June 22, 2023 11:27
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 22, 2023
@rm3l
Copy link
Member

rm3l commented Jun 23, 2023 •
edited
Loading

Not sure why, but the Podman tests consistently fail on GitHub with the same error: Error: k8s.gcr.io/pause:3.5: image not known

This was the first time I saw this kind of error..

I noticed the same error on other PRs as well, like with #6924 (https://github.com/redhat-developer/odo/actions/runs/5344975468/jobs/9690029602)

@rm3l
Copy link
Member

rm3l commented Jun 23, 2023

Not sure why, but the Podman tests consistently fail on GitHub with the same error: Error: k8s.gcr.io/pause:3.5: image not known

This was the first time I saw this kind of error..

I noticed the same error on other PRs as well, like with #6924 (redhat-developer/odo/actions/runs/5344975468/jobs/9690029602)

@valaparthvi Can you rebase your branch onto main? The tests on Podman should be passing now.

@valaparthvi valaparthvi force-pushed the 6806-provide-support-in-odo-version-for-podman branch from fb6adf1 to 93618eb Compare June 23, 2023 17:35
@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 23, 2023
@valaparthvi valaparthvi temporarily deployed to internal June 23, 2023 17:35 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@rm3l rm3l added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 24, 2023
@rm3l
Copy link
Member

rm3l commented Jun 24, 2023 

  << Timeline

  [FAILED] user-guides/quickstart/docs-mdx/java/java_odo_dev_output.mdx
  Expected
      <string>: Â Â (
      Â Â 	"""
      Â Â 	... // 12 identical lines
        	✓  Pod is Running
        	✓  Syncing files into the container [1s]
      - 	✓  Building your application in container (command: build) [1s]
      - 	•  Executing the application (command: run)  ...
      - 	✓  Waiting for the application to be ready [1s]
      -Â 	-  Forwarding from 127.0.0.1:20001 -> 8080
      + 	✗  Building your application in container (command: build) [1s]
      +Â 	Error occurred on Push - watch command was unable to push component: unable to exec command [/bin/sh -c cd ${PROJECT_SOURCE} && (mvn clean -Dmaven.repo.local=/home/user/.m2/repository package -Dmaven.test.skip=true) 1>>/proc/1/fd/1 2>>/proc/1/fd/2]: error while streaming command: command terminated with exit code 1
      Â Â 	
      Â Â 	
      Â Â 	... // 9 identical lines
      Â Â 	"""
      Â Â )
      
  to be empty
  In [It] at: /go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:256 @ 06/23/23 18:22:16.76
------------------------------
Spawning '/go/bin/odo init' from /tmp/3658003557
•

Summarizing 1 Failure:
  [FAIL] User guides: Quickstart test Java quickstart guide [It] should test the complete java springboot quickstart output in order
  /go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:256

Ran 5 of 5 Specs in 231.043 seconds
FAIL! -- 4 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestUserGuidesDocAutomation (231.06s)
FAIL

Unrelated.

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2023

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

Details

In response to this:

 << Timeline

 [FAILED] user-guides/quickstart/docs-mdx/java/java_odo_dev_output.mdx
 Expected
     <string>: Â Â (
     Â Â 	"""
     Â Â 	... // 12 identical lines
       	✓  Pod is Running
       	✓  Syncing files into the container [1s]
     - 	✓  Building your application in container (command: build) [1s]
     - 	•  Executing the application (command: run)  ...
     - 	✓  Waiting for the application to be ready [1s]
     -Â 	-  Forwarding from 127.0.0.1:20001 -> 8080
     + 	✗  Building your application in container (command: build) [1s]
     +Â 	Error occurred on Push - watch command was unable to push component: unable to exec command [/bin/sh -c cd ${PROJECT_SOURCE} && (mvn clean -Dmaven.repo.local=/home/user/.m2/repository package -Dmaven.test.skip=true) 1>>/proc/1/fd/1 2>>/proc/1/fd/2]: error while streaming command: command terminated with exit code 1
     Â Â 	
     Â Â 	
     Â Â 	... // 9 identical lines
     Â Â 	"""
     Â Â )
     
 to be empty
 In [It] at: /go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:256 @ 06/23/23 18:22:16.76
------------------------------
Spawning '/go/bin/odo init' from /tmp/3658003557
•

Summarizing 1 Failure:
 [FAIL] User guides: Quickstart test Java quickstart guide [It] should test the complete java springboot quickstart output in order
 /go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:256

Ran 5 of 5 Specs in 231.043 seconds
FAIL! -- 4 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestUserGuidesDocAutomation (231.06s)
FAIL

Unrelated.

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 2bafd31 into redhat-developer:main Jun 24, 2023
@openshift-merge-robot openshift-merge-robot temporarily deployed to internal June 24, 2023 20:46 — with GitHub Actions Inactive
@rm3l rm3l mentioned this pull request Jun 26, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

@feloy feloy Awaiting requested review from feloy

Assignees

@rm3l rm3l

Labels

kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide support in odo version for podman

3 participants

@valaparthvi @rm3l @openshift-merge-robot