Skip to content

Fix GitHub labels in release changelog generator script and PR template#6916

Merged
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
rm3l:cleanup_gh_labels
Jun 21, 2023
Merged

Fix GitHub labels in release changelog generator script and PR template#6916
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
rm3l:cleanup_gh_labels

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Jun 19, 2023 •
edited
Loading

What type of PR is this:
/area refactoring
/area release-eng

What does this PR do / why we need it:
This fixes the remaining places, after cleaning up all the labels we use in the repo: https://github.com/redhat-developer/odo/labels?sort=name-asc
I wanted to delete the kind/code-refactoring label (superseded by area/refactoring), but it was still being used here.
Also, the kind/tests label had been removed already in the past, but the changelog script was not updated accordingly.

Which issue(s) this PR fixes:
—

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
@rm3l rm3l added this to the v3.12.0 🚀 milestone Jun 19, 2023
@openshift-ci openshift-ci bot added the area/release-eng Issues or PRs related to the Release Engineering label Jun 19, 2023
@openshift-ci openshift-ci bot requested review from feloy and ritudes June 19, 2023 15:08
@netlify
Copy link

netlify bot commented Jun 19, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 643f173
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64906f5cf0ba0a0007d9558d

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023

Kubernetes Docs Tests on commit 0b012f3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023

OpenShift Tests on commit finished with errors.
View logs: TXT HTML

@rm3l rm3l requested review from valaparthvi and removed request for ritudes June 20, 2023 07:36
valaparthvi
valaparthvi approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On an unrelated note, we need to modify the IBM pipelines to not trigger a run when a change is made to .github and certain scripts.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 21, 2023
@valaparthvi
Copy link
Contributor

valaparthvi commented Jun 21, 2023

/override ODO-PODMAN-TEST
/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test

Overriding the above tests since their failure is not related to the changes in this PR.

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: ODO-PODMAN-TEST, OpenShift-Integration-tests/OpenShift-Integration-tests, windows-integration-test/Windows-test

Details

In response to this:

/override ODO-PODMAN-TEST
/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test

Overriding the above tests since their failure is not related to the changes in this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 4bc0668 into redhat-developer:main Jun 21, 2023
@rm3l rm3l deleted the cleanup_gh_labels branch June 21, 2023 09:36
@rm3l
Copy link
Member Author

rm3l commented Jun 21, 2023 •
edited
Loading

On an unrelated note, we need to modify the IBM pipelines to not trigger a run when a change is made to .github and certain scripts.

Yes, that would be nice. #6854 did a similar thing for doc-only changes, but we could extend this to ignore more changes.

EDIT: I've created #6918 to track this.

@rm3l rm3l mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feloy feloy Awaiting requested review from feloy

1 more reviewer

@valaparthvi valaparthvi valaparthvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@valaparthvi valaparthvi

Labels

area/refactoring Issues or PRs related to code refactoring area/release-eng Issues or PRs related to the Release Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

v3.12.0 🚀

Development

Successfully merging this pull request may close these issues.

3 participants

@rm3l @valaparthvi @openshift-merge-robot