Bump Alizer to fix potential panic when analyzing large projects#6926
Merged
openshift-merge-robot merged 3 commits intoredhat-developer:mainfrom Jun 27, 2023
Conversation
🔨 Deploy Preview deleted from internal cluster!
|
9bf274d to
3a76856
Compare
e2d9f53 to
81ceaa3
Compare
Amongst other things, this fixes an issue when analyzing large projects, by preventing potential panics when trying to detect application ports. [1] redhat-developer/alizer@14114f0
…d 'k8s.io/*' to the previous versions we had
Bumping Alizer bumped these packages to upper versions,
which seems to cause build errors due to Service Binding Operator
libraries not compatible with those new versions.
See the error below.
Since we don't want to update SBO libraries at this time
(as SBO is currently in maintenance mode only),
this makes sure we are using the versions it builds against.
Build error for reference:
```
go install -mod=vendor -ldflags="-X github.com/redhat-developer/odo/pkg/version.GITCOMMIT=cb9c13900" ./cmd/odo/
# github.com/redhat-developer/service-binding-operator/apis/spec/v1alpha3
vendor/github.com/redhat-developer/service-binding-operator/apis/spec/v1alpha3/servicebinding_webhook.go:44:27: cannot use &ServiceBinding{} (value of type *ServiceBinding) as type admission.Validator in variable declaration:
*ServiceBinding does not implement admission.Validator (wrong type for ValidateCreate method)
have ValidateCreate() error
want ValidateCreate() (warnings admission.Warnings, err error)
# github.com/redhat-developer/service-binding-operator/apis/binding/v1alpha1
vendor/github.com/redhat-developer/service-binding-operator/apis/binding/v1alpha1/servicebinding_webhook.go:37:27: cannot use &ServiceBinding{} (value of type *ServiceBinding) as type admission.Validator in variable declaration:
*ServiceBinding does not implement admission.Validator (wrong type for ValidateCreate method)
have ValidateCreate() error
want ValidateCreate() (warnings admission.Warnings, err error)
make: *** [Makefile:90: install] Error 2
```
81ceaa3 to
bf436eb
Compare
bf436eb to
8ac52eb
Compare
|
Kudos, SonarCloud Quality Gate passed! |
feloy
approved these changes
Jun 27, 2023
Member
Author
Issue with interactive tests - addressed in #6830 /override OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests |
|
@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








What type of PR is this:
/kind task
/area dependency
/area init
What does this PR do / why we need it:
This bumps Alizer to the latest commit at this time, which fixes an issue when analyzing large projects,
by preventing potential panics when trying to detect application ports (see redhat-developer/alizer#220).
Note:
As explained in the second commit, I had to downgrade and pin the versions of
sigs.k8s.io/controller-runtimeandk8s.io/*to the previous versions we had, because of build errors with Service Binding Operator libraries (which I did not want to upgrade).Build error for reference
Which issue(s) this PR fixes:
Fixes #6921
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
Try to run
odo analyze -o jsonagainst Backstage. It would panic before the changes here, but now it should return properly: