Move from github.com/feloy/devfile-builder#6937
Merged
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom Jun 29, 2023
Merged
Move from github.com/feloy/devfile-builder#6937openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
feloy
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
feloy
force-pushed
the
feature-6899/devfile-builder-init
branch
from
a68e052 to
d4a8fc4
Compare
feloy
force-pushed
the
feature-6899/devfile-builder-init
branch
from
d4a8fc4 to
4edcc1b
Compare
feloy
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
3 tasks
feloy
force-pushed
the
feature-6899/devfile-builder-init
branch
from
4edcc1b to
3c065e0
Compare
rm3l
requested changes
Jun 29, 2023
Member
rm3l
left a comment
rm3l
left a comment
There was a problem hiding this comment.
Also, can you add a GitHub Workflow to check that the wasm module builds correctly?
Contributor
Author
This wasm module will be removed with the next PR I'm working on, I would not bother with it |
Co-authored-by: Armel Soro <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Member
Ah yes, I forgot this. Indeed, makes sense then. |
rm3l
approved these changes
Jun 29, 2023
openshift-ci
bot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
Importd the Devfile builder sources from github.com/feloy/devfile-builder
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6899
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: