Skip to content

Document and return JSON data for API errors#6938

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
feloy:api-erreor-results
Jun 28, 2023
Merged

Document and return JSON data for API errors#6938
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
feloy:api-erreor-results

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Jun 28, 2023

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Fixes the API response data for the error cases, and documents these error responses in the openapi spec

@netlify
Copy link

netlify bot commented Jun 28, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit afbb946
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/649befda3f72220008408422
😎 Deploy Preview https://deploy-preview-6938--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 28, 2023
@feloy feloy requested a review from rm3l June 28, 2023 08:31
@openshift-ci openshift-ci bot requested review from anandrkskd and valaparthvi June 28, 2023 08:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

Kubernetes Docs Tests on commit c0127ce finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 28, 2023
@rm3l rm3l added this to the v3.13.0 🚀 milestone Jun 28, 2023
@feloy
Copy link
Contributor Author

feloy commented Jun 28, 2023

/override windows-integration-test/Windows-test

[FAILED] [137.366 seconds]
odo dev command with api server tests when the component is bootstrapped when odo is executed with --no-watch and --api-server flags [BeforeEach] when a file in component directory is modified when /component/command endpoint is POSTed should trigger a push
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4280/tests/integration/cmd_dev_api_server_test.go:180
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4280/tests/integration/cmd_dev_api_server_test.go:213
[...]
starterserver.go:78] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.

@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test

[FAILED] [137.366 seconds]
odo dev command with api server tests when the component is bootstrapped when odo is executed with --no-watch and --api-server flags [BeforeEach] when a file in component directory is modified when /component/command endpoint is POSTed should trigger a push
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4280/tests/integration/cmd_dev_api_server_test.go:180
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4280/tests/integration/cmd_dev_api_server_test.go:213
[...]
starterserver.go:78] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit c8a1414 into redhat-developer:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels

kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

v3.13.0 🚀

Development

Successfully merging this pull request may close these issues.

3 participants

@feloy @rm3l @openshift-merge-robot