Add .gitattributes file with Git-style path matchers customizing how PR changed files appear on GitHub#6940
Conversation
…hanged files appear on GitHub This should make it easier to review large PRs with a lot of changes from certain files (like in `**/vendor/**`), by hiding them by default.
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
|
Kudos, SonarCloud Quality Gate passed!
|
openshift-ci
bot
added
the
lgtm
|
/override NoCluster-Integration-tests/NoCluster-Integration-tests /override OpenShift-Integration-tests/OpenShift-Integration-tests Not related |
|
@feloy: Overrode contexts on behalf of feloy: NoCluster-Integration-tests/NoCluster-Integration-tests, OpenShift-Integration-tests/OpenShift-Integration-tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rm3l
deleted the
add-.gitattributes-to-customize-how-changed-files-appear-on-github
branch
3 participants
What type of PR is this:
/kind task
What does this PR do / why we need it:
GitHub UI is terribly slow when reviewing/commenting on PRs that contain a lot of changes in the vendored directories, like in #6937
As suggested in [1], we can keep certain files from displaying in diffs by default, by using a standard
.gitattributesfile.This should make it easier to review large PRs with a lot of changes from certain files (like in
**/vendor/**), by hiding them by default.[1] https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github f
This is how matching files would appear if
linguist-generatedattribute istrue; so it will still be possible to show the diff on demand if needed:Which issue(s) this PR fixes:
—
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: