Display list of commands from the local devfile in odo describe component output#6944
Merged
openshift-merge-robot merged 4 commits intoredhat-developer:mainfrom Jul 3, 2023
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
kind/feature
🔨 Deploy Preview deleted from internal cluster!
|
rm3l
added
the
area/devfile-spec
rm3l
changed the title
commands from the local devfile in odo describe component outputcommands from the local devfile in odo describe component output
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
feloy
approved these changes
Jul 3, 2023
openshift-ci
bot
added
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
openshift-merge-robot
temporarily deployed
to
internal
GitHub Actions
Inactive
rm3l
deleted the
6892-display-list-of-commands-from-the-local-devfile-in-odo-describe-component-output
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
This adds information about commands defined in the Devfile fro; the
odo describe componentoutput.Which issue(s) this PR fixes:
Fixes #6892
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
See #6892 for more context. When executed from a directory containing a Devfile,
odo describe componentshould now display the list of commands that are defined in the Devfile, if any.In the JSON output, this is available under a new
.devfileData.commandsfield.odo describe component -o json | jq -r '.devfileData.commands'
[ { "name": "install", "type": "exec", "group": "build", "isDefault": true, "commandLine": "npm install", "component": "runtime", "componentType": "container" }, { "name": "innerloop-pod-command", "type": "apply", "group": "test", "isDefault": false, "component": "innerloop-pod", "componentType": "kubernetes" }, { "name": "start", "type": "exec", "commandLine": "npm start", "component": "runtime", "componentType": "container" }, { "name": "run", "type": "composite", "group": "run", "isDefault": true }, { "name": "build-image", "type": "apply", "component": "prod-image", "componentType": "image", "imageName": "quay.io/tkral/devfile-nodejs-deploy:latest" }, { "name": "deploy-deployment", "type": "apply", "component": "outerloop-deploy", "componentType": "kubernetes" }, { "name": "deploy-another-deployment", "type": "apply", "component": "another-deployment", "componentType": "kubernetes" }, { "name": "outerloop-pod-command", "type": "apply", "component": "outerloop-pod", "componentType": "kubernetes" }, { "name": "deploy", "type": "composite", "group": "deploy", "isDefault": true } ]