Skip to content

[UX] Fix default value of ImageRegistry in odo preference view output#6951

Merged
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
valaparthvi:6947-ux-fix-default-value-of-imageregistry-in-odo-preference-view-output
Jul 5, 2023
Merged

[UX] Fix default value of ImageRegistry in odo preference view output#6951
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
valaparthvi:6947-ux-fix-default-value-of-imageregistry-in-odo-preference-view-output

Conversation

@valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Jul 5, 2023

What type of PR is this:
/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6947

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 5, 2023
@netlify
Copy link

netlify bot commented Jul 5, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit d2cc8a7
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64a5a9fbd9f03d00080ada0b

@openshift-ci openshift-ci bot requested review from feloy and rm3l July 5, 2023 12:56
@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit ed41625 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

NoCluster Tests on commit ed41625 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

Unit Tests on commit ed41625 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

Validate Tests on commit ed41625 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

Kubernetes Tests on commit ed41625 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

Windows Tests (OCP) on commit ed41625 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

OpenShift Tests on commit ed41625 finished successfully.
View logs: TXT HTML

rm3l
rm3l requested changes Jul 5, 2023
View reviewed changes
@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 3b73c80 finished successfully.
View logs: TXT HTML

rm3l
rm3l approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Parthvi!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 5, 2023
@rm3l rm3l closed this Jul 5, 2023
@rm3l rm3l reopened this Jul 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@openshift-merge-robot openshift-merge-robot merged commit 5911930 into redhat-developer:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

@feloy feloy Awaiting requested review from feloy

Assignees

@rm3l rm3l

Labels

kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[UX] Fix default value of ImageRegistry in odo preference view output

3 participants

@valaparthvi @rm3l @openshift-merge-robot