Skip to content

odo dev --logs#6957

Merged
openshift-merge-robot merged 4 commits intoredhat-developer:mainfrom
feloy:feature-5716/odo-dev-logs
Jul 7, 2023
Merged

odo dev --logs#6957
openshift-merge-robot merged 4 commits intoredhat-developer:mainfrom
feloy:feature-5716/odo-dev-logs

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Jul 7, 2023 •
edited
Loading

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #5716

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jul 7, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit c857827
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64a8044f35e4f6000883fe8a

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jul 7, 2023
@feloy feloy changed the title odo dev --logs [wip] odo dev --logs Jul 7, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 7, 2023
@openshift-ci openshift-ci bot requested review from kadel and rm3l July 7, 2023 07:52
@odo-robot
Copy link

odo-robot bot commented Jul 7, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 5c3138c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 7, 2023 •
edited
Loading

NoCluster Tests on commit 5c3138c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 7, 2023 •
edited
Loading

Unit Tests on commit 5c3138c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 7, 2023 •
edited
Loading

Validate Tests on commit 5c3138c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 7, 2023 •
edited
Loading

Kubernetes Tests on commit 5c3138c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 7, 2023 •
edited
Loading

OpenShift Tests on commit 5c3138c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 7, 2023 •
edited
Loading

Windows Tests (OCP) on commit 5c3138c finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 7, 2023 •
edited
Loading

Kubernetes Docs Tests on commit ebe003e finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-5716/odo-dev-logs branch from 147baf8 to c857827 Compare July 7, 2023 12:25
@feloy feloy changed the title [wip] odo dev --logs odo dev --logs Jul 7, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 7, 2023
@rm3l
Copy link
Member

rm3l commented Jul 7, 2023 

...
  [odo] I0707 07:49:55.039580    7892 starterserver.go:93] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
...

Summarizing 1 Failure:
  [FAIL] odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag [BeforeEach] when /component/command endpoint is POSTed should trigger a push
  C:/Users/Administrator.ANSIBLE-TEST-VS/4355/tests/helper/helper_run.go:50

Ran 382 of 940 Specs in 1254.936 seconds
FAIL! -- 381 Passed | 1 Failed | 0 Pending | 558 Skipped

Port conflicts on Windows - reported in #6939

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

Details

In response to this:

...
 [odo] I0707 07:49:55.039580    7892 starterserver.go:93] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
...

Summarizing 1 Failure:
 [FAIL] odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag [BeforeEach] when /component/command endpoint is POSTed should trigger a push
 C:/Users/Administrator.ANSIBLE-TEST-VS/4355/tests/helper/helper_run.go:50

Ran 382 of 940 Specs in 1254.936 seconds
FAIL! -- 381 Passed | 1 Failed | 0 Pending | 558 Skipped

Port conflicts on Windows - reported in #6939

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 9624721 into redhat-developer:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels

kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

odo dev should have --logs flag

3 participants

@feloy @rm3l @openshift-merge-robot