Generate static UI files from within a container#6972
Merged
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom Jul 18, 2023
Merged
Conversation
…lity For some reason, Angular was not generating the same hash for the `runtime*.js` file (even with the same content), causing the 'check-ui-static-files' job to sometimes fail. Leveraging a container (as we are already doing for the 'generate-apiserver' and 'generate-apifront' tasks) should allow for more predictable output. Co-authored-by: Philippe Martin <[email protected]>
openshift-ci
bot
added
the
area/refactoring
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
|
Kudos, SonarCloud Quality Gate passed!
|
feloy
approved these changes
Jul 18, 2023
Contributor
feloy
left a comment
feloy
left a comment
There was a problem hiding this comment.
Thanks for the improvement
openshift-ci
bot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/area refactoring
/area dev
What does this PR do / why we need it:
CI started failing on #6970 - see https://github.com/redhat-developer/odo/actions/runs/5573055638/jobs/10179819175?pr=6970
But running
make ui-staticlocally on my machine returned no diff. The behavior was different on CI and on other machines.Similar behavior was noticed even on the
mainbranch.For some reason, Angular was not generating the same hash for the
runtime*.jsfile (even with the same content), causing the 'check-ui-static-files' job to sometimes fail.Leveraging a container (as we are already doing for the
generate-apiserverandgenerate-apifronttasks) should allow for more stable output.Which issue(s) this PR fixes:
odo dev#6934PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
make ui-static # No changes to expect git diff