Skip to content

Makes stopped command terminate normally#7011

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
feloy:bugfix-6486/stopped-command
Aug 2, 2023
Merged

Makes stopped command terminate normally#7011
openshift-merge-robot merged 1 commit intoredhat-developer:mainfrom
feloy:bugfix-6486/stopped-command

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Aug 1, 2023

What type of PR is this:

/kind bug

What does this PR do / why we need it:

This PR makes a command stopped appear as terminating normally.

This is do by removing the remote pid file before to kill the process.

Which issue(s) this PR fixes:

Fixes #6486

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 1, 2023
@netlify
Copy link

netlify bot commented Aug 1, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 709fba1
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64c8ecc3ca7aaa00086650dd

@feloy feloy requested a review from rm3l August 1, 2023 09:38
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 1, 2023
@openshift-ci openshift-ci bot requested a review from kadel August 1, 2023 09:38
@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 3128294 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

NoCluster Tests on commit 3128294 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

Unit Tests on commit 3128294 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

Validate Tests on commit 3128294 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

Kubernetes Tests on commit 3128294 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

Windows Tests (OCP) on commit 3128294 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

OpenShift Tests on commit 3128294 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the bugfix-6486/stopped-command branch from 7fcc172 to c980d07 Compare August 1, 2023 11:20
@feloy feloy force-pushed the bugfix-6486/stopped-command branch from c980d07 to 709fba1 Compare August 1, 2023 11:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023

Kubernetes Docs Tests on commit 49e38f5 finished successfully.
View logs: TXT HTML

@feloy feloy changed the title [wip] Makes stopped command terminate normally Makes stopped command terminate normally Aug 1, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 1, 2023
@feloy feloy removed the request for review from kadel August 1, 2023 12:35
@rm3l rm3l added the area/dev Issues or PRs related to `odo dev` label Aug 2, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 2, 2023
@feloy
Copy link
Contributor Author

feloy commented Aug 2, 2023

/override windows-integration-test/Windows-test

[FAILED] [3.721 seconds]
odo init interactive command tests label nocluster [It] should start downloading starter project only after all interactive questions have been asked [nocluster]
C:/Users/Administrator.ANSIBLE-TEST-VS/4439/tests/integration/interactive_init_test.go:546

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test

[FAILED] [3.721 seconds]
odo init interactive command tests label nocluster [It] should start downloading starter project only after all interactive questions have been asked [nocluster]
C:/Users/Administrator.ANSIBLE-TEST-VS/4439/tests/integration/interactive_init_test.go:546

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 4361b9f into redhat-developer:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels

area/dev Issues or PRs related to `odo dev` kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restarting application makes it look like it failure

3 participants

@feloy @rm3l @openshift-merge-robot